Add asynchronous test suite runner to Dart rewrite of test scripts.

tests/corelib/test_config.dart

+// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#library("corelib_test_config");
+
+#import("../../tools/testing/dart/test_runner.dart");
+
+class CorelibTestSuite {
+  final String VM_PATH = 

[Mads Ager (google), 2011/11/08 08:26:06]

Need something else here.

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+    "/usr/local/google/home/whesse/dart/out/Debug_ia32/dart_bin";
+
+  Function handleTest;
+  Function doneCallback;

[Mads Ager (google), 2011/11/08 08:26:06]

Can we make the naming more uniform here? 

handleTest, handleDone? 

testCallback, doneCallback?

onTest, onDone?

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+  final String directoryPath = "tests/corelib/src";

[Mads Ager (google), 2011/11/08 08:26:06]

This only works in the top-level directory, right?

Also, it would be nice to group the final members at the top.

[Bill Hesse, 2011/11/08 14:38:56]

Now it also works in the runtime directory.

On 2011/11/08 08:26:06, Mads Ager wrote:
Done.

+
+  CorelibTestSuite();
+
+  void getTests(Function callback ,[Function done = null]) {

[Mads Ager (google), 2011/11/08 08:26:06]

Maybe some other name that indicates that we do not get a collection of tests
here? forEachTest?

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+    handleTest = callback;
+    doneCallback = done;
+    processDirectory();
+  }
+
+  void processDirectory() {
+    Directory dir = new Directory(directoryPath);
+    if (!dir.existsSync()) return null;

[Mads Ager (google), 2011/11/08 08:26:06]

Just 'return' instead of 'return null'?

Could you add a "TODO(ager): Use dir.errorHandler instead when directory
implementation correctly uses the error callback."

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+    dir.fileHandler = processFile;
+    dir.doneHandler = doneCallback;
+    dir.list(false);
+  }
+
+  void processFile(String filename) {
+    if (filename.endsWith("Test.dart")) {

[Mads Ager (google), 2011/11/08 08:26:06]

Let's not check for "Test.dart" but only for ".dart". We really should rename
all the tests to lower_case_underscore.

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+      // TODO(whesse): Gather test case info from status file and test file.
+      handleTest(new TestCase(filename, VM_PATH,

[Mads Ager (google), 2011/11/08 08:26:06]

I would have one argument per line to make it more readable.

TestCase(filename,
         VM_PATH,
         ...);

[Bill Hesse, 2011/11/08 14:38:56]

Done.

+                              ["--enable_type_checks",
+                               "--ignore-unrecognized-flags",
+                               filename ],
+                              completeHandler,
+                              new Set.from([PASS, FAIL, CRASH, TIMEOUT])));
+    }
+  }
+  
+  void completeHandler(TestCase testCase) {
+    print("Exit code: ${testCase.output.exitCode}    Time: ${testCase.output.time}");

[Mads Ager (google), 2011/11/08 08:26:06]

Long line.

+  }
+}