Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 8492004: Fix lazy deoptimization at HInvokeFunction and enable target-recording call-function stub. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: added nop-padding and assertions on all platforms Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2086 matching lines...) Expand 10 before | Expand all | Expand 10 after
2097 int arg_count = args->length(); 2097 int arg_count = args->length();
2098 { PreservePositionScope scope(masm()->positions_recorder()); 2098 { PreservePositionScope scope(masm()->positions_recorder());
2099 for (int i = 0; i < arg_count; i++) { 2099 for (int i = 0; i < arg_count; i++) {
2100 VisitForStackValue(args->at(i)); 2100 VisitForStackValue(args->at(i));
2101 } 2101 }
2102 } 2102 }
2103 // Record source position for debugger. 2103 // Record source position for debugger.
2104 SetSourcePosition(expr->position()); 2104 SetSourcePosition(expr->position());
2105 2105
2106 // Record call targets in unoptimized code, but not in the snapshot. 2106 // Record call targets in unoptimized code, but not in the snapshot.
2107 // TODO(1789): Reenable temporarily disabled recording CallFunctionStub 2107 bool record_call_target = !Serializer::enabled();
2108 // when the issue is fixed.
2109 bool record_call_target = false && !Serializer::enabled();
2110 if (record_call_target) { 2108 if (record_call_target) {
2111 flags = static_cast<CallFunctionFlags>(flags | RECORD_CALL_TARGET); 2109 flags = static_cast<CallFunctionFlags>(flags | RECORD_CALL_TARGET);
2112 } 2110 }
2113 CallFunctionStub stub(arg_count, flags); 2111 CallFunctionStub stub(arg_count, flags);
2114 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize)); 2112 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));
2115 __ CallStub(&stub, expr->id()); 2113 __ CallStub(&stub, expr->id());
2116 if (record_call_target) { 2114 if (record_call_target) {
2117 // There is a one element cache in the instruction stream. 2115 // There is a one element cache in the instruction stream.
2118 #ifdef DEBUG 2116 #ifdef DEBUG
2119 int return_site_offset = masm()->pc_offset(); 2117 int return_site_offset = masm()->pc_offset();
(...skipping 2225 matching lines...) Expand 10 before | Expand all | Expand 10 after
4345 *context_length = 0; 4343 *context_length = 0;
4346 return previous_; 4344 return previous_;
4347 } 4345 }
4348 4346
4349 4347
4350 #undef __ 4348 #undef __
4351 4349
4352 } } // namespace v8::internal 4350 } } // namespace v8::internal
4353 4351
4354 #endif // V8_TARGET_ARCH_IA32 4352 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698