Chromium Code Reviews Chromium Code Reviews
Issue
8492004:
Fix lazy deoptimization at HInvokeFunction and enable target-recording call-function stub. (Closed)
DescriptionFix lazy deoptimization at HInvokeFunction and enable target-recording call-function stub.
Changes the way we do lazy deoptimization:
1. For side-effect instructions, we insert the lazy-deopt call at
the following LLazyBailout instruction.
CALL
GAP
LAZY-BAILOUT ==> lazy-deopt-call
2. For other instructions (StackCheck) we insert it right after the
instruction since the deopt targets an earlier deoptimization environment.
STACK-CHECK
GAP ==> lazy-deopt-call
The pc of the lazy-deopt call that will be patched in is recorded in the
deoptimization input data. Each Lithium instruction can have 0..n safepoints.
All safepoints get the deoptimization index of the associated LAZY-BAILOUT
instruction. On lazy deoptimization we use the return-pc to find the safepoint.
The safepoint tells us the deoptimization index, which in turn finds us the
PC where to insert the lazy-deopt-call.
Additional changes:
* RegExpLiteral marked it as having side-effects so that it
gets an explicitlazy-bailout instruction (instead of
treating it specially like stack-checks)
* Enable target recording CallFunctionStub to achieve
more inlining on optimized code.
BUG=v8:1789
TEST=jslint and uglify run without crashing, mjsunit/compiler/regress-lazy-deopt.js
Committed: http://code.google.com/p/v8/source/detail?r=10006
Patch Set 1 #Patch Set 2 : working ia32 version #Patch Set 3 : fixed resizing of reloc info, --print-code flag and presubmit errors #Patch Set 4 : added unit test #
Total comments: 14
Patch Set 5 : addressed comments #Patch Set 6 : Port to x64 and ARM. #Patch Set 7 : fixed missing deopt index on ARM. #
Total comments: 8
Patch Set 8 : '' #Patch Set 9 : added nop-padding and assertions on all platforms #
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
