Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 8491067: Add another histogram related suppression (Closed)

Created:
9 years, 1 month ago by jar (doing other things)
Modified:
9 years, 1 month ago
Reviewers:
dhollowa
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Add another histogram related suppression Histograms are found via a locked function, and then placed into static atomic variables. They allow for racing with a second thread that emplants the same pointer into that atomic variable. r=dhollowa BUG=104776 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jar (doing other things)
9 years, 1 month ago (2011-11-20 23:59:43 UTC) #1
dhollowa
lgtm LGTM.
9 years, 1 month ago (2011-11-21 04:06:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/8491067/1
9 years, 1 month ago (2011-11-21 04:06:24 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 05:37:22 UTC) #4
Change committed as 110885

Powered by Google App Engine
This is Rietveld 408576698