Issue 8491065: Uncomment third IPC hook for about:profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8491065: Uncomment third IPC hook for about:profiler (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Uncomment third IPC hook for about:profiler If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109760

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ipc/ipc_message_macros.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages