Fix accelerated plugins rendering in Panels on Mac.

Fix accelerated plugins rendering in Panels on Mac.

I couldn't figure out a test. The fix makes Panel NSWindow non-opaque, which makes the GL surface behind it visible through 'transparent black hole' that AcceleratedPluginView is cutting for the plugin's redering.

BUG=103303
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110156

[jennb, 2011-11-12 01:35:17]

Does this eliminate the need for the existence of ThemedBrowserWindow
which Daniel separated out from ChromeBrowserWindow in 7734003? If so,
perhaps we should undo that separation in this patch as well.

On Fri, Nov 11, 2011 at 5:24 PM,  <dimich@chromium.org> wrote:
> Reviewers: dcheng,
>
> Description:
> Fix accelerated plugins rendering in Panels on Mac.
>
> I couldn't figure out a test. The fix makes Panel NSWindow non-opaque, which
> makes the GL surface behind it visible through 'transparent black hole' that
> AcceleratedPluginView is cutting for the plugin's redering.
>
> BUG=103303
>
>
> Please review this at http://codereview.chromium.org/8491063/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/panels/panel_window_controller_cocoa.h
>
>
> Index: chrome/browser/ui/panels/panel_window_controller_cocoa.h
> diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.h
> b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
> index
>
15dbeb5af6f7520dc857a1a1b68c57645b33e392..c3e33c480e070e07f433a47a69ecd10869ac3206
> 100644
> --- a/chrome/browser/ui/panels/panel_window_controller_cocoa.h
> +++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.h
> @@ -16,8 +16,8 @@
>  #include "base/memory/scoped_ptr.h"
>  #include "base/time.h"
>  #import "chrome/browser/ui/cocoa/browser_command_executor.h"
> +#import "chrome/browser/ui/cocoa/chrome_browser_window.h"
>  #import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
> -#import "chrome/browser/ui/cocoa/themed_browser_window.h"
>  #import "chrome/browser/ui/cocoa/themed_window.h"
>  #import "chrome/browser/ui/cocoa/tracking_area.h"
>
> @@ -25,7 +25,7 @@
>  class PanelBrowserWindowCocoa;
>  @class PanelTitlebarViewCocoa;
>
> -@interface PanelWindowCocoaImpl : ThemedBrowserWindow {
> +@interface PanelWindowCocoaImpl : ChromeBrowserWindow {
>  }
>  // The panels cannot be reduced to 3-px windows on the edge of the screen
>  // active area (above Dock). Default constraining logic makes at least a
> height
>
>
>

[Dmitry Titov, 2011-11-15 01:08:25]

Removed ThemedBrowserWindow. PTAL.

[dcheng, 2011-11-15 01:17:30]

On 2011/11/15 01:08:25, Dmitry Titov wrote:
> Removed ThemedBrowserWindow. PTAL.

Do we need to update the xib? I think that has a reference to
ThemedBrowserWindow still.

[Dmitry Titov, 2011-11-15 01:48:25]

Nope, we got our own even more-derived PanelWindowCocoaImpl that XIB is now
pointing to.

[jennb, 2011-11-15 01:59:42]

Thanks for making that cleanup. LGTM if LGTDcheng.

On Mon, Nov 14, 2011 at 5:08 PM,  <dimich@chromium.org> wrote:
> Removed ThemedBrowserWindow. PTAL.
>
> http://codereview.chromium.org/8491063/
>

[dcheng, 2011-11-15 02:04:13]

lgtm
On Nov 14, 2011 5:59 PM, "Jenn Braithwaite (胡慧鋒)" <jennb@chromium.org>
wrote:

> Thanks for making that cleanup. LGTM if LGTDcheng.
>
> On Mon, Nov 14, 2011 at 5:08 PM,  <dimich@chromium.org> wrote:
> > Removed ThemedBrowserWindow. PTAL.
> >
> > http://codereview.chromium.org/8491063/
> >
>

[commit-bot: I haz the power, 2011-11-15 18:47:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dimich@chromium.org/8491063/6001

[commit-bot: I haz the power, 2011-11-15 20:26:35]

Change committed as 110156