Fixes GetContainerBounds in tab_contents_view_mac.mm

chrome/browser/tab_contents/tab_contents_view_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
 
 #include "chrome/browser/tab_contents/tab_contents_view_mac.h"
 
 #include <string>
 
@@ skipping 131 matching lines @@
   if (!rwhv)
     return NULL;
   return rwhv->GetNativeView();
 }
 
 gfx::NativeWindow TabContentsViewMac::GetTopLevelNativeWindow() const {
   return [cocoa_view_.get() window];
 }
 
 void TabContentsViewMac::GetContainerBounds(gfx::Rect* out) const {
-  *out = [cocoa_view_.get() flipNSRectToRect:[cocoa_view_.get() bounds]];
+  NSPoint origin = [[cocoa_view_.get() window] frame].origin;

[Avi (use Gerrit), 2011/11/12 01:42:00]

This line gets the window origin in global coordinates...

+
+  // Flip coordinates based on the primary screen.
+  NSScreen* screen = [[NSScreen screens] objectAtIndex:0];
+  NSSize size = [cocoa_view_.get() frame].size;

[Avi (use Gerrit), 2011/11/12 01:42:00]

...and this line gets the size of the view in its parent coordinates...

+  origin.y = [screen frame].size.height - origin.y - size.height;

[Avi (use Gerrit), 2011/11/12 01:42:00]

...and this line mixes up values from two totally different objects and their
different coordinate systems...

+  NSRect bounds = NSMakeRect(origin.x, origin.y, size.width, size.height);

[Avi (use Gerrit), 2011/11/12 01:42:00]

...as does this line. What is GetContainerBounds supposed to return? The
window's bounds? The TCV's? Please do so.

Please familiarize yourself with the -convertXxxx:toView: methods. Use them.

+  *out = gfx::Rect(NSRectToCGRect(bounds));
 }
 
 void TabContentsViewMac::StartDragging(
     const WebDropData& drop_data,
     WebDragOperationsMask allowed_operations,
     const SkBitmap& image,
     const gfx::Point& image_offset) {
   // By allowing nested tasks, the code below also allows Close(),
   // which would deallocate |this|.  The same problem can occur while
   // processing -sendEvent:, so Close() is deferred in that case.
@@ skipping 434 matching lines @@
       [[[notification userInfo] objectForKey:kSelectionDirection]
         unsignedIntegerValue];
   if (direction == NSDirectSelection)
     return;
 
   [self tabContents]->
       FocusThroughTabTraversal(direction == NSSelectingPrevious);
 }
 
 @end