Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 8491054: Request power status update from power manager when power button view gets created. (Closed)

Created:
9 years, 1 month ago by tbarzic
Modified:
9 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Request power status update from power manager when power button view gets created. Also, prepare PowerManagerDbusClient for change in power manager for bug chromium-os:21360 TEST=manual BUG=chromium-os:20832 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109777

Patch Set 1 #

Patch Set 2 : nit in a comment #

Total comments: 2

Patch Set 3 : comment #

Patch Set 4 : remove power_manager_client.cc part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/status/power_menu_button.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tbarzic
Satoru, could you please take a look :)
9 years, 1 month ago (2011-11-11 20:54:02 UTC) #1
satorux1
LGTM, with one nit. http://codereview.chromium.org/8491054/diff/4/chrome/browser/chromeos/dbus/power_manager_client.cc File chrome/browser/chromeos/dbus/power_manager_client.cc (right): http://codereview.chromium.org/8491054/diff/4/chrome/browser/chromeos/dbus/power_manager_client.cc#newcode211 chrome/browser/chromeos/dbus/power_manager_client.cc:211: // This is a temp ...
9 years, 1 month ago (2011-11-11 21:00:22 UTC) #2
tbarzic
http://codereview.chromium.org/8491054/diff/4/chrome/browser/chromeos/dbus/power_manager_client.cc File chrome/browser/chromeos/dbus/power_manager_client.cc (right): http://codereview.chromium.org/8491054/diff/4/chrome/browser/chromeos/dbus/power_manager_client.cc#newcode211 chrome/browser/chromeos/dbus/power_manager_client.cc:211: // This is a temp hack that will be ...
9 years, 1 month ago (2011-11-11 21:09:33 UTC) #3
tbarzic
Steven and Dave, could one of you give me a lgtm for this (I need ...
9 years, 1 month ago (2011-11-11 22:02:38 UTC) #4
DaveMoore
lgtm
9 years, 1 month ago (2011-11-12 00:53:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8491054/3002
9 years, 1 month ago (2011-11-12 02:27:14 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-12 07:14:15 UTC) #7
Change committed as 109777

Powered by Google App Engine
This is Rietveld 408576698