Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: content/renderer/media/audio_input_message_filter.h

Issue 8491044: Link things together and enable the device selection for linux and mac. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: fixing unittests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_input_message_filter.h
diff --git a/content/renderer/media/audio_input_message_filter.h b/content/renderer/media/audio_input_message_filter.h
index 89fdd54933f71cf2f3310cdd3239dc36e4eda6ac..f44059b996fc5aef4b7fb005ed2818e48010d2b1 100644
--- a/content/renderer/media/audio_input_message_filter.h
+++ b/content/renderer/media/audio_input_message_filter.h
@@ -39,7 +39,7 @@ class AudioInputMessageFilter : public IPC::ChannelProxy::MessageFilter {
// Called when the device referenced by the index has been started in
// the browswer process.
- virtual void OnDeviceReady(int index) = 0;
+ virtual void OnDeviceReady(const std::string& index) = 0;
henrika (OOO until Aug 14) 2011/11/16 13:24:02 uid? And why do you change name of callback here?
no longer working on chromium 2011/11/16 17:45:48 We can talk more on which name to use.
protected:
virtual ~Delegate() {}
@@ -82,7 +82,7 @@ class AudioInputMessageFilter : public IPC::ChannelProxy::MessageFilter {
void OnStreamStateChanged(int stream_id, AudioStreamState state);
// Notification of the opened device of an audio session.
- void OnDeviceStarted(int stream_id, int index);
+ void OnDeviceStarted(int stream_id, const std::string& device_uid);
// A map of stream ids to delegates.
IDMap<Delegate> delegates_;

Powered by Google App Engine
This is Rietveld 408576698