Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.h

Issue 8491044: Link things together and enable the device selection for linux and mac. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: fixing unittests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.h
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.h b/content/browser/renderer_host/media/audio_input_renderer_host.h
index 8daa31fcd6d04c216f1f2848529105a8cb1695ea..334fe781956818b7d36d0eb49f0a4c038d9c1f3e 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.h
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.h
@@ -21,9 +21,9 @@
//
// For the OnStartDevice() request, AudioInputRendererHost starts the device
// referenced by the session id, and a OnDeviceStarted() callback with the
henrika (OOO until Aug 14) 2011/11/16 13:24:02 an
no longer working on chromium 2011/11/16 17:45:48 Done.
-// index of the opened device will be received later. Then it will send a IPC
-// message to notify the renderer that the device is ready, so that renderer
-// can continue with the OnCreateStream() request.
+// unique_id of the opened device will be received later. Then it will send a
henrika (OOO until Aug 14) 2011/11/16 13:24:02 don't use variable names up here
no longer working on chromium 2011/11/16 17:45:48 Done.
+// IPC message to notify the renderer that the device is ready, so that
+// renderer can continue with the OnCreateStream() request.
//
// OnDeviceStopped() is called when the user closes the device through
// AudioInputDeviceManager without calling Stop() before. What
@@ -122,7 +122,7 @@ class CONTENT_EXPORT AudioInputRendererHost
uint32 size);
// media_stream::AudioInputDeviceManagerEventHandler implementation.
- virtual void OnDeviceStarted(int session_id, int index);
+ virtual void OnDeviceStarted(int session_id, const std::string& device_uid);
virtual void OnDeviceStopped(int session_id);
private:
@@ -144,7 +144,8 @@ class CONTENT_EXPORT AudioInputRendererHost
// required properties.
void OnCreateStream(int stream_id,
const AudioParameters& params,
- bool low_latency);
+ bool low_latency,
+ const std::string& device_uid);
// Record the audio input stream referenced by |stream_id|.
void OnRecordStream(int stream_id);

Powered by Google App Engine
This is Rietveld 408576698