Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: src/objects.h

Issue 8491041: Fix missing fast property accessors in heap snapshots. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1868 matching lines...) Expand 10 before | Expand all | Expand 10 after
1879 int number_of_fast_used_elements_; 1879 int number_of_fast_used_elements_;
1880 int number_of_fast_unused_elements_; 1880 int number_of_fast_unused_elements_;
1881 int number_of_slow_used_elements_; 1881 int number_of_slow_used_elements_;
1882 int number_of_slow_unused_elements_; 1882 int number_of_slow_unused_elements_;
1883 }; 1883 };
1884 1884
1885 void IncrementSpillStatistics(SpillInformation* info); 1885 void IncrementSpillStatistics(SpillInformation* info);
1886 #endif 1886 #endif
1887 Object* SlowReverseLookup(Object* value); 1887 Object* SlowReverseLookup(Object* value);
1888 1888
1889 // Getters and setters are stored in a fixed array property.
1890 // These are constants for their indices.
1891 static const int kGetterIndex = 0;
mnaganov (inactive) 2011/11/14 11:04:24 Funny enough, your code wasn't compiling with gcc
1892 static const int kSetterIndex = 1;
1893
1889 // Maximal number of fast properties for the JSObject. Used to 1894 // Maximal number of fast properties for the JSObject. Used to
1890 // restrict the number of map transitions to avoid an explosion in 1895 // restrict the number of map transitions to avoid an explosion in
1891 // the number of maps for objects used as dictionaries. 1896 // the number of maps for objects used as dictionaries.
1892 inline int MaxFastProperties(); 1897 inline int MaxFastProperties();
1893 1898
1894 // Maximal number of elements (numbered 0 .. kMaxElementCount - 1). 1899 // Maximal number of elements (numbered 0 .. kMaxElementCount - 1).
1895 // Also maximal value of JSArray's length property. 1900 // Also maximal value of JSArray's length property.
1896 static const uint32_t kMaxElementCount = 0xffffffffu; 1901 static const uint32_t kMaxElementCount = 0xffffffffu;
1897 1902
1898 // Constants for heuristics controlling conversion of fast elements 1903 // Constants for heuristics controlling conversion of fast elements
(...skipping 5967 matching lines...) Expand 10 before | Expand all | Expand 10 after
7866 } else { 7871 } else {
7867 value &= ~(1 << bit_position); 7872 value &= ~(1 << bit_position);
7868 } 7873 }
7869 return value; 7874 return value;
7870 } 7875 }
7871 }; 7876 };
7872 7877
7873 } } // namespace v8::internal 7878 } } // namespace v8::internal
7874 7879
7875 #endif // V8_OBJECTS_H_ 7880 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698