Cleanup FileBrowser.Create.* UMA events

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 var g_slideshow_data = null;
@@ skipping 38 matching lines @@
   this.currentButter_ = null;
 
   // True if we should filter out files that start with a dot.
   this.filterFiles_ = true;
 
   this.commands_ = {};
 
   this.document_ = dialogDom.ownerDocument;
   this.dialogType_ = this.params_.type || FileManager.DialogType.FULL_PAGE;
 
-  metrics.recordAction('Create.' + this.dialogType_);
+  metrics.recordEnum('Create', this.dialogType_,
+      [FileManager.DialogType.SELECT_FOLDER,
+      FileManager.DialogType.SELECT_SAVEAS_FILE,
+      FileManager.DialogType.SELECT_OPEN_FILE,
+      FileManager.DialogType.SELECT_OPEN_MULTI_FILE,
+      FileManager.DialogType.FULL_PAGE]);
 
   this.initDialogs_();
 
   // TODO(dgozman): This will be changed to LocaleInfo.
   this.locale_ = new v8Locale(navigator.language);
 
   // TODO(rginda): 6/22/11: Remove this test when createDateTimeFormat is
   // available in all chrome trunk builds.
   if ('createDateTimeFormat' in this.locale_) {
     this.shortDateFormatter_ =
@@ skipping 2850 matching lines @@
    * Rescans the current directory immediately, refreshing the list. Should NOT
    * be used in most cases. Instead use rescanDirectory_.
    *
    * @param {function()} opt_callback Optional function to invoke when the
    *     rescan is complete.
    */
   FileManager.prototype.rescanDirectoryNow_ = function(opt_callback) {
     var self = this;
     var reader;
 
+    function rescanDone() {
+      metrics.recordTime('ScanDirectory');
+      if (self.currentDirEntry_.fullPath == DOWNLOADS_DIRECTORY)
+        metrics.reportCount("DownloadsCount", self.dataModel_.length);
+      if (opt_callback)
+        opt_callback();
+    }
+
     metrics.startInterval('ScanDirectory');
 
     function onReadSome(entries) {
       if (entries.length == 0) {
-        metrics.recordTime('ScanDirectory');
-        if (opt_callback)
-          opt_callback();
+        rescanDone();
         return;
       }
 
       // Splice takes the to-be-spliced-in array as individual parameters,
       // rather than as an array, so we need to perform some acrobatics...
       var spliceArgs = [].slice.call(entries);
 
       // Hide files that start with a dot ('.').
       // TODO(rginda): User should be able to override this.  Support for other
       // commonly hidden patterns might be nice too.
@@ skipping 28 matching lines @@
       return;
     }
 
     // Otherwise, use the provided list of root subdirectories, since the
     // real local filesystem root directory (the one we use outside the
     // harness) can't be enumerated yet.
     var spliceArgs = [].slice.call(this.rootEntries_);
     spliceArgs.unshift(0, 0);  // index, deleteCount
     self.dataModel_.splice.apply(self.dataModel_, spliceArgs);
 
-    metrics.recordTime('ScanDirectory');
-    if (opt_callback)
-      opt_callback();
+    rescanDone();
   };
 
   FileManager.prototype.findListItem_ = function(event) {
     var node = event.srcElement;
     while (node) {
       if (node.tagName == 'LI')
         break;
       node = node.parentNode;
     }
 
@@ skipping 635 matching lines @@
           });
       }, onError);
 
       function onError(err) {
         console.log('Error while checking free space: ' + err);
         setTimeout(doCheck, 1000 * 60);
       }
     }
   }
 })();