Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/runtime.cc

Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Unified our 2 UpdateCaches implementations, making some assumptions more explicit Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/property.h ('k') | src/v8globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10388 matching lines...) Expand 10 before | Expand all | Expand 10 after
10399 } else { 10399 } else {
10400 return heap->undefined_value(); 10400 return heap->undefined_value();
10401 } 10401 }
10402 } 10402 }
10403 case INTERCEPTOR: 10403 case INTERCEPTOR:
10404 case MAP_TRANSITION: 10404 case MAP_TRANSITION:
10405 case ELEMENTS_TRANSITION: 10405 case ELEMENTS_TRANSITION:
10406 case CONSTANT_TRANSITION: 10406 case CONSTANT_TRANSITION:
10407 case NULL_DESCRIPTOR: 10407 case NULL_DESCRIPTOR:
10408 return heap->undefined_value(); 10408 return heap->undefined_value();
10409 default: 10409 case HANDLER:
10410 UNREACHABLE(); 10410 UNREACHABLE();
10411 return heap->undefined_value();
10411 } 10412 }
10412 UNREACHABLE(); 10413 UNREACHABLE(); // keep the compiler happy
10413 return heap->undefined_value(); 10414 return heap->undefined_value();
10414 } 10415 }
10415 10416
10416 10417
10417 // Get debugger related details for an object property. 10418 // Get debugger related details for an object property.
10418 // args[0]: object holding property 10419 // args[0]: object holding property
10419 // args[1]: name of the property 10420 // args[1]: name of the property
10420 // 10421 //
10421 // The array returned contains the following information: 10422 // The array returned contains the following information:
10422 // 0: Property value 10423 // 0: Property value
(...skipping 3111 matching lines...) Expand 10 before | Expand all | Expand 10 after
13534 } else { 13535 } else {
13535 // Handle last resort GC and make sure to allow future allocations 13536 // Handle last resort GC and make sure to allow future allocations
13536 // to grow the heap without causing GCs (if possible). 13537 // to grow the heap without causing GCs (if possible).
13537 isolate->counters()->gc_last_resort_from_js()->Increment(); 13538 isolate->counters()->gc_last_resort_from_js()->Increment();
13538 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags); 13539 isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
13539 } 13540 }
13540 } 13541 }
13541 13542
13542 13543
13543 } } // namespace v8::internal 13544 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/property.h ('k') | src/v8globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698