Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: src/objects-inl.h

Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Unified our 2 UpdateCaches implementations, making some assumptions more explicit Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1847 matching lines...) Expand 10 before | Expand all | Expand 10 after
1858 return reinterpret_cast<AccessorDescriptor*>(p->foreign_address()); 1858 return reinterpret_cast<AccessorDescriptor*>(p->foreign_address());
1859 } 1859 }
1860 1860
1861 1861
1862 bool DescriptorArray::IsProperty(int descriptor_number) { 1862 bool DescriptorArray::IsProperty(int descriptor_number) {
1863 return GetType(descriptor_number) < FIRST_PHANTOM_PROPERTY_TYPE; 1863 return GetType(descriptor_number) < FIRST_PHANTOM_PROPERTY_TYPE;
1864 } 1864 }
1865 1865
1866 1866
1867 bool DescriptorArray::IsTransition(int descriptor_number) { 1867 bool DescriptorArray::IsTransition(int descriptor_number) {
1868 PropertyType t = GetType(descriptor_number); 1868 return IsTransitionType(GetType(descriptor_number));
1869 return t == MAP_TRANSITION || t == CONSTANT_TRANSITION ||
1870 t == ELEMENTS_TRANSITION;
1871 } 1869 }
1872 1870
1873 1871
1874 bool DescriptorArray::IsNullDescriptor(int descriptor_number) { 1872 bool DescriptorArray::IsNullDescriptor(int descriptor_number) {
1875 return GetType(descriptor_number) == NULL_DESCRIPTOR; 1873 return GetType(descriptor_number) == NULL_DESCRIPTOR;
1876 } 1874 }
1877 1875
1878 1876
1879 bool DescriptorArray::IsDontEnum(int descriptor_number) { 1877 bool DescriptorArray::IsDontEnum(int descriptor_number) {
1880 return PropertyDetails(GetDetails(descriptor_number)).IsDontEnum(); 1878 return PropertyDetails(GetDetails(descriptor_number)).IsDontEnum();
(...skipping 2726 matching lines...) Expand 10 before | Expand all | Expand 10 after
4607 #undef WRITE_INT_FIELD 4605 #undef WRITE_INT_FIELD
4608 #undef READ_SHORT_FIELD 4606 #undef READ_SHORT_FIELD
4609 #undef WRITE_SHORT_FIELD 4607 #undef WRITE_SHORT_FIELD
4610 #undef READ_BYTE_FIELD 4608 #undef READ_BYTE_FIELD
4611 #undef WRITE_BYTE_FIELD 4609 #undef WRITE_BYTE_FIELD
4612 4610
4613 4611
4614 } } // namespace v8::internal 4612 } } // namespace v8::internal
4615 4613
4616 #endif // V8_OBJECTS_INL_H_ 4614 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698