More sanity unittests to make sure AddressSanitizer is instrumenting the code.

More sanity unittests to make sure AddressSanitizer is instrumenting the code.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108994

[Alexander Potapenko, 2011-11-07 12:18:52]

Nico, can you please take a look?

[Nico, 2011-11-07 15:32:26]

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc
File base/tools_sanity_unittest.cc (right):

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:137: int volatile array[5];
You probably don't need this volatile

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:139: int volatile *access = &(array[5]);
This volatile probably needs to be to the right of *.

nit: I'd leave out the () parens.

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:144: int volatile g_asan_test_global_array[10];
You shouldn't need this volatile either. Also, don't indent in namespaces.

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:153: int volatile *access =
g_asan_test_global_array - 1;
To the right of * as well.

[Alexander Potapenko, 2011-11-07 16:10:44]

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc
File base/tools_sanity_unittest.cc (right):

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:137: int volatile array[5];
On 2011/11/07 15:32:26, Nico wrote:
> You probably don't need this volatile

Done.

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:139: int volatile *access = &(array[5]);
On 2011/11/07 15:32:26, Nico wrote:
> This volatile probably needs to be to the right of *.
> 
> nit: I'd leave out the () parens.

Done.

http://codereview.chromium.org/8491013/diff/1/base/tools_sanity_unittest.cc#n...
base/tools_sanity_unittest.cc:153: int volatile *access =
g_asan_test_global_array - 1;
On 2011/11/07 15:32:26, Nico wrote:
> To the right of * as well.

Done.

[Nico, 2011-11-07 16:11:53]

lgtm