MIPS: Enable serialization for MIPS architecture.

src/serialize.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 743 matching lines @@
   } else if (space_number == CELL_SPACE) {                                     \
     dest_space = isolate->heap()->cell_space();                                \
   } else {                                                                     \
     ASSERT(space_number >= LO_SPACE);                                          \
     dest_space = isolate->heap()->lo_space();                                  \
   }
 
 
 static const int kUnknownOffsetFromStart = -1;
 
+static const int kInstructionsForSplitImmediate = 3*kPointerSize;

[Erik Corry, 2011/12/21 09:33:55]

Inconsistency: This constant is premultiplied by kPOinterSize, whereas
kInstructionsFor32BitConstant is measured in instructions and has to be
multiplied by kInstructionSize when used.

[kisg, 2011/12/22 15:30:14]

We will change the naming.
This constant is only used in MIPS specific code (see below), and kInstrSize is
not defined on all architectures. Should we put it simply inside #ifdef
V8_TARGET_ARCH_MIPS?

 
 void Deserializer::ReadChunk(Object** current,
                              Object** limit,
                              int source_space,
                              Address current_object_address) {
   Isolate* const isolate = isolate_;
   bool write_barrier_needed = (current_object_address != NULL &&
                                source_space != NEW_SPACE &&
                                source_space != CELL_SPACE &&
                                source_space != CODE_SPACE &&
@@ skipping 52 matching lines @@
             }                                                                  \
           }                                                                    \
           if (within == kFirstInstruction) {                                   \
             Code* new_code_object = reinterpret_cast<Code*>(new_object);       \
             new_object = reinterpret_cast<Object*>(                            \
                 new_code_object->instruction_start());                         \
           }                                                                    \
           if (how == kFromCode) {                                              \
             Address location_of_branch_data =                                  \
                 reinterpret_cast<Address>(current);                            \
-            Assembler::set_target_at(location_of_branch_data,                  \
+            Address patch_site = location_of_branch_data;                      \
+            if (Assembler::kCallTargetSize == 0) {                             \

[Erik Corry, 2011/12/21 09:33:55]

The size of a call target is only relevant if we are dealing with a call
instruction.  In that case 'within == kFirstInstruction' so we will get into the
'if' just below, which already sets current_was_incremented.  In other words I
think this can be simplified.

[kisg, 2011/12/22 15:30:14]

Actually, this is a subtle way of saying #ifdef MIPS, because only MIPS has call
target size set to 0. We need to change the patch site because we use the LUI /
ORI instruction pair. So the other option would be to use #if
V8_TARGET_ARCH_MIPS instead of the regular if. This is always needed, not just
when within == kFirstInstruction.
Another possibility would be to add a comment explaining, that this is required
by MIPS for handling the LUI / ORI pair.

Which way would you prefer?

+              current_was_incremented = true;                                  \
+              patch_site -= kInstructionsForSplitImmediate;                    \
+            }                                                                  \
+            Assembler::set_target_at(patch_site,                               \
                                      reinterpret_cast<Address>(new_object));   \
             if (within == kFirstInstruction) {                                 \
               location_of_branch_data += Assembler::kCallTargetSize;           \
               current = reinterpret_cast<Object**>(location_of_branch_data);   \
               current_was_incremented = true;                                  \
             }                                                                  \
           } else {                                                             \
             *current = new_object;                                             \
           }                                                                    \
         }                                                                      \
@@ skipping 113 matching lines @@
         Object* object = current[-1];
         ASSERT(!isolate->heap()->InNewSpace(object));
         for (int i = 0; i < repeats; i++) current[i] = object;
         current += repeats;
         break;
       }
 
       // Deserialize a new object and write a pointer to it to the current
       // object.
       ONE_PER_SPACE(kNewObject, kPlain, kStartOfObject)
+      // Deserialize a new object from pointer found in code and write
+      // a pointer to it to the current object. Required only for MIPS.
+      ONE_PER_SPACE(kNewObject, kFromCode, kStartOfObject)

[Erik Corry, 2011/12/21 09:33:55]

I'm a bit worried about the code size here.  The deserialization is performance
critical for startup and context creation, and this macro expands a lot.  I'd
like this to be in an ifdef MIPS.  The others in this file don't expand as much.

[kisg, 2011/12/22 15:30:14]

Done.

       // Support for direct instruction pointers in functions
       ONE_PER_CODE_SPACE(kNewObject, kPlain, kFirstInstruction)
       // Deserialize a new code object and write a pointer to its first
       // instruction to the current code object.
       ONE_PER_SPACE(kNewObject, kFromCode, kFirstInstruction)
       // Find a recently deserialized object using its offset from the current
       // allocation point and write a pointer to it to the current object.
       ALL_SPACES(kBackref, kPlain, kStartOfObject)
       // Find a recently deserialized code object using its offset from the
+      // current allocation point and write a pointer to it to the current
+      // object. Required only for MIPS.
+      ALL_SPACES(kBackref, kFromCode, kStartOfObject)
+      // Find a recently deserialized code object using its offset from the
       // current allocation point and write a pointer to its first instruction
       // to the current code object or the instruction pointer in a function
       // object.
       ALL_SPACES(kBackref, kFromCode, kFirstInstruction)
       ALL_SPACES(kBackref, kPlain, kFirstInstruction)
       // Find an already deserialized object using its offset from the start
       // and write a pointer to it to the current object.
       ALL_SPACES(kFromStart, kPlain, kStartOfObject)
       ALL_SPACES(kFromStart, kPlain, kFirstInstruction)
       // Find an already deserialized code object using its offset from the
       // start and write a pointer to its first instruction to the current code
       // object.
       ALL_SPACES(kFromStart, kFromCode, kFirstInstruction)
+      // Find an already deserialized code object using its offset from
+      // the start and write a pointer to it to the current object.
+      // Required only for MIPS.
+      ALL_SPACES(kFromStart, kFromCode, kStartOfObject)
       // Find an object in the roots array and write a pointer to it to the
       // current object.
       CASE_STATEMENT(kRootArray, kPlain, kStartOfObject, 0)
       CASE_BODY(kRootArray, kPlain, kStartOfObject, 0, kUnknownOffsetFromStart)
+      // Required only for MIPS.
+      CASE_STATEMENT(kRootArray, kFromCode, kStartOfObject, 0)

[Erik Corry, 2011/12/21 09:33:55]

Can we replace these with LoadRoot which does the load relative to a root array
array and needs no relocation info?

[kisg, 2011/12/22 15:30:14]

Could you please elaborate this a bit in more detail? We are not completely sure
what you would like to see here.

+      CASE_BODY(kRootArray,
+                kFromCode,
+                kStartOfObject,
+                0,
+                kUnknownOffsetFromStart)
       // Find an object in the partial snapshots cache and write a pointer to it
       // to the current object.
       CASE_STATEMENT(kPartialSnapshotCache, kPlain, kStartOfObject, 0)
       CASE_BODY(kPartialSnapshotCache,
                 kPlain,
                 kStartOfObject,
                 0,
                 kUnknownOffsetFromStart)
       // Find an code entry in the partial snapshots cache and
       // write a pointer to it to the current object.
@@ skipping 665 matching lines @@
       fullness_[space] = RoundUp(fullness_[space], Page::kPageSize);
     }
   }
   int allocation_address = fullness_[space];
   fullness_[space] = allocation_address + size;
   return allocation_address;
 }
 
 
 } }  // namespace v8::internal