Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 8490029: GTK: Move code shared by future content/ classes and chrome/ to ui/. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
jam, sky
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Move code shared by future content/ classes and chrome/ to ui/. BUG=93804 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111193

Patch Set 1 #

Patch Set 2 : Remove platform_util method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -111 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/gtk/focus_store_gtk.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/gtk/focus_store_gtk.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A + ui/base/gtk/focus_store_gtk.h View 2 chunks +10 lines, -6 lines 0 comments Download
A + ui/base/gtk/focus_store_gtk.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
9 years, 1 month ago (2011-11-21 20:55:33 UTC) #1
jam
lgtm
9 years, 1 month ago (2011-11-21 23:57:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8490029/3001
9 years, 1 month ago (2011-11-22 01:25:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 8490029-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-22 01:25:41 UTC) #4
Elliot Glaysher
+sky for owners stamp on the gyp file.
9 years, 1 month ago (2011-11-22 01:28:17 UTC) #5
sky
LGTM
9 years, 1 month ago (2011-11-22 15:49:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8490029/3001
9 years, 1 month ago (2011-11-22 17:32:20 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 19:47:35 UTC) #8
Change committed as 111193

Powered by Google App Engine
This is Rietveld 408576698