Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: runtime/vm/parser.cc

Issue 8490019: Capturing for loop variables correctly (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 1268)
+++ runtime/vm/parser.cc (working copy)
@@ -4363,6 +4363,18 @@
ExpectToken(Token::kRPAREN);
const bool parsing_loop_body = true;
SequenceNode* body = ParseNestedStatement(parsing_loop_body, NULL);
+
+ // Check whether any of the variables in the initializer part of
+ // the for statement are captured by a closure. If so, we insert a
+ // node that creates a new Context at the end of the loop body (but
+ // before the increment expression is evaluated).
+ for (int i = 0; i < init_scope->num_variables(); i++) {
+ if (init_scope->VariableAt(i)->is_captured() &&
+ (init_scope->VariableAt(i)->owner() == init_scope)) {
+ body->Add(new CloneContextNode(for_pos));
+ break;
+ }
+ }
CloseBlock();
return new ForNode(for_pos,
label,
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698