Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/autofill/autofill_metrics_unittest.cc

Issue 8490017: Setting up external delegate calls to allow a future delegate to handle autofill (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Hard coding input element position Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_metrics_unittest.cc
diff --git a/chrome/browser/autofill/autofill_metrics_unittest.cc b/chrome/browser/autofill/autofill_metrics_unittest.cc
index ea307c7c45bda6b6c6e8c667fde7e0382402a7b6..8805448ae9046bfc64b00d0255fe6ed909e58435 100644
--- a/chrome/browser/autofill/autofill_metrics_unittest.cc
+++ b/chrome/browser/autofill/autofill_metrics_unittest.cc
@@ -22,6 +22,7 @@
#include "content/test/test_browser_thread.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gfx/rect.h"
#include "webkit/glue/form_data.h"
#include "webkit/glue/form_field.h"
@@ -976,12 +977,12 @@ TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {
LogAddressSuggestionsCount(2)).Times(1);
// Simulate activating the autofill popup for the phone field.
- autofill_manager_->OnQueryFormFieldAutofill(0, form, field);
+ autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect());
// Simulate activating the autofill popup for the email field after typing.
// No new metric should be logged, since we're still on the same page.
autofill_test::CreateTestFormField("Email", "email", "b", "email", &field);
- autofill_manager_->OnQueryFormFieldAutofill(0, form, field);
+ autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect());
// Reset the autofill manager state.
autofill_manager_->Reset();
@@ -993,7 +994,7 @@ TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {
LogAddressSuggestionsCount(1)).Times(1);
// Simulate activating the autofill popup for the email field after typing.
- autofill_manager_->OnQueryFormFieldAutofill(0, form, field);
+ autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect());
// Reset the autofill manager state again.
autofill_manager_->Reset();
@@ -1006,7 +1007,7 @@ TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {
// Simulate activating the autofill popup for the email field after typing.
form.fields[0].is_autofilled = true;
- autofill_manager_->OnQueryFormFieldAutofill(0, form, field);
+ autofill_manager_->OnQueryFormFieldAutofill(0, form, field, gfx::Rect());
}
// Test that we log whether Autofill is enabled when filling a form.
« no previous file with comments | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/common/autofill_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698