Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.h

Issue 8490017: Setting up external delegate calls to allow a future delegate to handle autofill (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Hard coding input element position Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete_history_manager_unittest.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_external_delegate.h
diff --git a/chrome/browser/autofill/autofill_external_delegate.h b/chrome/browser/autofill/autofill_external_delegate.h
index 7a88c9813fe7b074ce0d182cda22799134111131..edc4104867d94db644245bca4fbd12f2c5be5879 100644
--- a/chrome/browser/autofill/autofill_external_delegate.h
+++ b/chrome/browser/autofill/autofill_external_delegate.h
@@ -13,6 +13,10 @@
class AutofillManager;
class TabContentsWrapper;
+namespace gfx {
+class Rect;
+}
+
namespace webkit_glue {
struct FormData;
struct FormField;
@@ -30,14 +34,19 @@ class AutofillExternalDelegate {
void SelectAutofillSuggestionAtIndex(int listIndex);
// Records and associates a query_id with web form data. Called
- // when the renderer posts an Autofill query to the browser.
+ // when the renderer posts an Autofill query to the browser. |bounds|
+ // is window relative.
virtual void OnQuery(int query_id,
const webkit_glue::FormData& form,
- const webkit_glue::FormField& field) = 0;
+ const webkit_glue::FormField& field,
+ const gfx::Rect& bounds) = 0;
// Records query results. Displays them to the user with an external
// Autofill popup that lives completely in the browser. Called when
// an Autofill query result is available.
+ // TODO(csharp): This should contain the logic found in
+ // AutofillAgent::OnSuggestionsReturned.
+ // See http://crbug.com/51644
virtual void OnSuggestionsReturned(
int query_id,
const std::vector<string16>& autofill_values,
@@ -45,6 +54,9 @@ class AutofillExternalDelegate {
const std::vector<string16>& autofill_icons,
const std::vector<int>& autofill_unique_ids) = 0;
+ // Hide the Autofill poup.
+ virtual void HideAutofillPopup() = 0;
+
// Platforms that wish to implement an external Autofill delegate
// MUST implement this. The 1st arg is the tab contents that owns
// this delegate; the second is the Autofill manager owned by the
« no previous file with comments | « chrome/browser/autocomplete_history_manager_unittest.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698