Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autofill/autofill_external_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
 #pragma once
 
 #include <vector>
 
 #include "base/string16.h"
 
 class AutofillManager;
 class TabContentsWrapper;
 
+namespace gfx {
+class Rect;
+}
+
 namespace webkit_glue {
 struct FormData;
 struct FormField;
 }  // namespace webkit_glue
 
 // Delegate for external processing of Autocomplete and Autofill
 // display and selection.
 class AutofillExternalDelegate {
  public:
   virtual ~AutofillExternalDelegate();
 
   // When using an external Autofill delegate.  Allows Chrome to tell
   // WebKit which Autofill selection has been chosen.
   // TODO(jrg): add feedback mechanism for hover on relevant platforms.
   void SelectAutofillSuggestionAtIndex(int listIndex);
 
   // Records and associates a query_id with web form data.  Called
   // when the renderer posts an Autofill query to the browser.
   virtual void OnQuery(int query_id,
                        const webkit_glue::FormData& form,
                        const webkit_glue::FormField& field) = 0;
 
   // Records query results.  Displays them to the user with an external
   // Autofill popup that lives completely in the browser.  Called when
   // an Autofill query result is available.
+  // TODO(csharp): This should contain the logic found in
+  // AutofillAgent::OnSuggestionsReturned.

[Ilya Sherman, 2011/11/09 20:34:19]

nit: Please add a link to http://crbug.com/51644 here (or file a new, more
focused bug for this, if you prefer).

[csharp, 2011/11/10 18:09:32]

Done.

   virtual void OnSuggestionsReturned(
       int query_id,
       const std::vector<string16>& autofill_values,
       const std::vector<string16>& autofill_labels,
       const std::vector<string16>& autofill_icons,
       const std::vector<int>& autofill_unique_ids) = 0;
 
+  // Set the bounds of the element we are providing the Autofill data
+  // for. The bounds are page-relative.

[Ilya Sherman, 2011/11/09 20:34:19]

nit: Two spaces after a sentence-final period, please (in Autofill code, at
least).

[csharp, 2011/11/10 18:09:32]

Done.

What is the reason for the two spaces? I don't remember seeing it in the style
guide.

On 2011/11/09 20:34:19, Ilya Sherman wrote:

[Ilya Sherman, 2011/11/10 21:19:41]

Yeah, it's not defined one way or the other in the style guide, so different
parts of the Chrome codebase do this differently.  It doesn't matter
particularly much, but it's nice to have consistency within a file.  For the
Autofill code, we've generally preferred two spaces to one.

(This is, admittedly, largely a carry-over from typewriters and early computer
fonts.  Modern computer fonts tend to be designed so that the period already has
a bit of extra space after it, which arguably makes the second space
unnecessary.  But David and I both think that two spaces still looks better in
code, which uses a monospaced font.)

On 2011/11/10 18:09:32, csharp wrote:

+  virtual void SetAutofillElementBounds(const gfx::Rect& bounds) = 0;
+
+  // Hide the Autofill poup.
+  virtual void HideAutofillPopup() = 0;
+
   // Platforms that wish to implement an external Autofill delegate
   // MUST implement this.  The 1st arg is the tab contents that owns
   // this delegate; the second is the Autofill manager owned by the
   // tab contents.
   static AutofillExternalDelegate* Create(TabContentsWrapper*,
                                           AutofillManager*);
 
  protected:
   explicit AutofillExternalDelegate(TabContentsWrapper* tab_contents_wrapper);
 
  private:
   TabContentsWrapper* tab_contents_wrapper_;  // weak; owns me.
 
   DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_