Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/autofill/autofill_manager.h

Issue 8490017: Setting up external delegate calls to allow a future delegate to handle autofill (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 const webkit_glue::FormData& form, 147 const webkit_glue::FormData& form,
148 const webkit_glue::FormField& field); 148 const webkit_glue::FormField& field);
149 void OnFillAutofillFormData(int query_id, 149 void OnFillAutofillFormData(int query_id,
150 const webkit_glue::FormData& form, 150 const webkit_glue::FormData& form,
151 const webkit_glue::FormField& field, 151 const webkit_glue::FormField& field,
152 int unique_id); 152 int unique_id);
153 void OnShowAutofillDialog(); 153 void OnShowAutofillDialog();
154 void OnDidPreviewAutofillFormData(); 154 void OnDidPreviewAutofillFormData();
155 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp); 155 void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
156 void OnDidShowAutofillSuggestions(bool is_new_popup); 156 void OnDidShowAutofillSuggestions(bool is_new_popup);
157 void ShowAutofillSuggestions(
158 int query_id,
159 const std::vector<string16>& autofill_values,
160 const std::vector<string16>& autofill_labels,
161 const std::vector<string16>& autofill_icons,
162 const std::vector<int>& autofill_unique_ids);
163 void SetAutofillElementBounds(int x, int y, int width, int height);
164 void HideAutofillPopup();
Ilya Sherman 2011/11/07 21:48:49 nit: These should be prefixed with "On", e.g. "OnH
csharp1 2011/11/08 19:59:00 Done.
157 165
158 // Fills |host| with the RenderViewHost for this tab. 166 // Fills |host| with the RenderViewHost for this tab.
159 // Returns false if Autofill is disabled or if the host is unavailable. 167 // Returns false if Autofill is disabled or if the host is unavailable.
160 bool GetHost(const std::vector<AutofillProfile*>& profiles, 168 bool GetHost(const std::vector<AutofillProfile*>& profiles,
161 const std::vector<CreditCard*>& credit_cards, 169 const std::vector<CreditCard*>& credit_cards,
162 RenderViewHost** host) const WARN_UNUSED_RESULT; 170 RenderViewHost** host) const WARN_UNUSED_RESULT;
163 171
164 // Unpacks |unique_id| and fills |profile| or |credit_card| with the 172 // Unpacks |unique_id| and fills |profile| or |credit_card| with the
165 // appropriate data source. Returns false if the unpacked id cannot be found. 173 // appropriate data source. Returns false if the unpacked id cannot be found.
166 bool GetProfileOrCreditCard(int unique_id, 174 bool GetProfileOrCreditCard(int unique_id,
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 TestTabContentsWithExternalDelegate); 330 TestTabContentsWithExternalDelegate);
323 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, 331 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
324 UserHappinessFormLoadAndSubmission); 332 UserHappinessFormLoadAndSubmission);
325 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 333 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
326 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FormFillDuration); 334 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FormFillDuration);
327 335
328 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 336 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
329 }; 337 };
330 338
331 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_ 339 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698