[filebrowser] Historgram for the file browser's open time.

[filebrowser] Histogram for the file browser's open time.

BUG=chromium-os:20553
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109017

[Vladislav Kaznacheev, 2011-11-07 12:39:44]

Please review

[SeRya, 2011-11-07 13:29:23]

LGTM

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/metrics.js (right):

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/metrics.js:30: console.log(name + ': '
+ elapsed + 'ms');
I think we we shouldn't litter in the common log by default (at least without
strong reason).

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/main.html:80: <script
src="js/util.js"></script>
Why not here? Would be nice to see the whole list of included files in one
place.

[Vladislav Kaznacheev, 2011-11-08 11:06:20]

Thanks for the review, committing.

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/metrics.js (right):

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/metrics.js:30: console.log(name + ': '
+ elapsed + 'ms');
I suggest keeping this for the time being because these numbers are actually
very useful while we are fighting for the startup performance. Once we are done
with that we shall clean the logging up.

On 2011/11/07 13:29:23, SeRya wrote:
> I think we we shouldn't litter in the common log by default (at least without
> strong reason).

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/8490014/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/main.html:80: <script
src="js/util.js"></script>
We want metrics.js to be as close to the top as possible as it record the
timestamp required to time the Javascrip parsing time. Added a comment.

On 2011/11/07 13:29:23, SeRya wrote:
> Why not here? Would be nice to see the whole list of included files in one
> place.

[commit-bot: I haz the power, 2011-11-08 11:15:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8490014/4001

[commit-bot: I haz the power, 2011-11-08 13:26:04]

Change committed as 109017