src/messages.js - Issue 8490008: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 8490008: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.js

===================================================================

--- src/messages.js (revision 9884)

+++ src/messages.js (working copy)

@@ -745,12 +745,9 @@

hasBeenSet = true;

value = v;

}

- var desc = { get: getter,

- set: setter,

- enumerable: false,

- configurable: true };

- desc = ToPropertyDescriptor(desc);

- DefineOwnProperty(obj, name, desc, true);

+ var flag = DONT_ENUM;

+ %DefineOrRedefineAccessorProperty(obj, name, GETTER, getter, flag);

+ %DefineOrRedefineAccessorProperty(obj, name, SETTER, setter, flag);

Lasse Reichstein 2011/11/07 08:51:04 Inline flag.

}

function CallSite(receiver, fun, pos) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »