Chromium Code Reviews

Side by Side Diff: src/messages.js

Issue 8490008: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 727 matching lines...)
738 return value; 738 return value;
739 } 739 }
740 hasBeenSet = true; 740 hasBeenSet = true;
741 value = fun(obj); 741 value = fun(obj);
742 return value; 742 return value;
743 } 743 }
744 function setter(v) { 744 function setter(v) {
745 hasBeenSet = true; 745 hasBeenSet = true;
746 value = v; 746 value = v;
747 } 747 }
748 var desc = { get: getter, 748 var flag = DONT_ENUM;
749 set: setter, 749 %DefineOrRedefineAccessorProperty(obj, name, GETTER, getter, flag);
750 enumerable: false, 750 %DefineOrRedefineAccessorProperty(obj, name, SETTER, setter, flag);
Lasse Reichstein 2011/11/07 08:51:04 Inline flag.
751 configurable: true };
752 desc = ToPropertyDescriptor(desc);
753 DefineOwnProperty(obj, name, desc, true);
754 } 751 }
755 752
756 function CallSite(receiver, fun, pos) { 753 function CallSite(receiver, fun, pos) {
757 this.receiver = receiver; 754 this.receiver = receiver;
758 this.fun = fun; 755 this.fun = fun;
759 this.pos = pos; 756 this.pos = pos;
760 } 757 }
761 758
762 function CallSiteGetThis() { 759 function CallSiteGetThis() {
763 return this.receiver; 760 return this.receiver;
(...skipping 425 matching lines...)
1189 throw e; 1186 throw e;
1190 } 1187 }
1191 } 1188 }
1192 1189
1193 1190
1194 InstallFunctions($Error.prototype, DONT_ENUM, ['toString', ErrorToString]); 1191 InstallFunctions($Error.prototype, DONT_ENUM, ['toString', ErrorToString]);
1195 1192
1196 // Boilerplate for exceptions for stack overflows. Used from 1193 // Boilerplate for exceptions for stack overflows. Used from
1197 // Isolate::StackOverflow(). 1194 // Isolate::StackOverflow().
1198 const kStackOverflowBoilerplate = MakeRangeError('stack_overflow', []); 1195 const kStackOverflowBoilerplate = MakeRangeError('stack_overflow', []);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine