Issue 8490008: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8490008: Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty. (Closed)

Created:
9 years, 1 month ago by Rico

Modified:
9 years, 1 month ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize DefineOneShotAccessor in messages.js to not call DefineOwnProperty. Committed: http://code.google.com/p/v8/source/detail?r=9886

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/messages.js	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 1 month ago (2011-11-07 08:51:04 UTC) #2

LGTM

http://codereview.chromium.org/8490008/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/8490008/diff/1/src/messages.js#newcode750
src/messages.js:750: %DefineOrRedefineAccessorProperty(obj, name, SETTER,
setter, flag);
Inline flag.

Expand Messages | Collapse Messages