Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: chrome/browser/chrome_browser_main.h

Issue 8488015: Revert 110327 - Add ChromeBrowserParts for non main parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.h
===================================================================
--- chrome/browser/chrome_browser_main.h (revision 110349)
+++ chrome/browser/chrome_browser_main.h (working copy)
@@ -9,7 +9,6 @@
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
-#include "base/memory/scoped_vector.h"
#include "base/metrics/field_trial.h"
#include "base/tracked_objects.h"
#include "chrome/browser/first_run/first_run.h"
@@ -18,7 +17,6 @@
class BrowserInit;
class BrowserProcessImpl;
-class ChromeBrowserMainExtraParts;
class FieldTrialSynchronizer;
class HistogramSynchronizer;
class MetricsService;
@@ -45,14 +43,23 @@
public:
virtual ~ChromeBrowserMainParts();
- // Add additional ChromeBrowserMainExtraParts.
- virtual void AddParts(ChromeBrowserMainExtraParts* parts);
+ // Constructs metrics service and does related initialization, including
+ // creation of field trials. Call only after labs have been converted to
+ // switches.
+ MetricsService* SetupMetricsAndFieldTrials(PrefService* local_state);
+ const content::MainFunctionParams& parameters() const {
+ return parameters_;
+ }
+ const CommandLine& parsed_command_line() const {
+ return parsed_command_line_;
+ }
+
protected:
explicit ChromeBrowserMainParts(
const content::MainFunctionParams& parameters);
- // content::BrowserMainParts overrides.
+ // content::BrowserParts overrides
virtual void PreEarlyInitialization() OVERRIDE;
virtual void PostEarlyInitialization() OVERRIDE;
virtual void ToolkitInitialized() OVERRIDE;
@@ -65,15 +72,6 @@
// Displays a warning message that we can't find any locale data files.
virtual void ShowMissingLocaleMessageBox() = 0;
- const content::MainFunctionParams& parameters() const {
- return parameters_;
- }
- const CommandLine& parsed_command_line() const {
- return parsed_command_line_;
- }
-
- Profile* profile() { return profile_; }
-
private:
// Methods for |EarlyInitialization()| ---------------------------------------
@@ -106,11 +104,6 @@
// Methods for |SetupMetricsAndFieldTrials()| --------------------------------
- // Constructs metrics service and does related initialization, including
- // creation of field trials. Call only after labs have been converted to
- // switches.
- MetricsService* SetupMetricsAndFieldTrials(PrefService* local_state);
-
static MetricsService* InitializeMetrics(
const CommandLine& parsed_command_line,
const PrefService* local_state);
@@ -122,6 +115,7 @@
// Methods for Main Message Loop -------------------------------------------
int PreMainMessageLoopRunImpl();
+ void StartBrowserOrUITask();
// Members initialized on construction ---------------------------------------
@@ -143,9 +137,6 @@
// SetupMetricsAndFieldTrials is called.
scoped_ptr<base::FieldTrialList> field_trial_list_;
- // Vector of additional ChromeBrowserMainExtraParts.
- ScopedVector<ChromeBrowserMainExtraParts> chrome_extra_parts_;
-
// Members initialized after / released before main_message_loop_ ------------
scoped_ptr<BrowserInit> browser_init_;
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698