Issue 8488012: Fix for management API related to escalated permissions disabled extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8488012: Fix for management API related to escalated permissions disabled extensions (Closed)

Created:
9 years, 1 month ago by asargent_no_longer_on_chrome

Modified:
9 years, 1 month ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for management API related to escalated permissions disabled extensions The general approach is to require user gesture and put up the confirmation UI if an extension wants to re-enable a disabled-due-to-permissions-escalation extension. Also added some new infrastructure for making this easier to test. (This is re-landing http://codereview.chromium.org/8423069/ which had a compile error on the cros_tegra2 bot) BUG=102579 TEST=See bug TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110376

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased again #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+427 lines, -93 lines)			Patch
M	chrome/browser/extensions/extension_function.h	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function.cc	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function_test_utils.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_test_utils.cc	View	2 chunks	+55 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.h	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.cc	View	4 chunks	+38 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.h	View	3 chunks	+23 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.cc	View	14 chunks	+95 lines, -67 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api_browsertest.cc	View	2 chunks	+86 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_install_browsertest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/management.html	View	1 chunk	+68 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/management/test/basics.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download