Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 8488011: Moving AutofillAgent Logic into Browser (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Uncommenting HideAutofillPopup call Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index 8d9b1349c96fa4c6a8a7ba748518125dba0788d3..7c029a04d2aa67646cba4973396d22962278652c 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -68,6 +68,14 @@ class AutofillManager : public TabContentsObserver,
external_delegate_ = delegate;
}
+ // Called from our external delegate so they cannot be private.
+ void OnFillAutofillFormData(int query_id,
+ const webkit_glue::FormData& form,
+ const webkit_glue::FormField& field,
+ int unique_id);
+ void OnDidShowAutofillSuggestions(bool is_new_popup);
+ void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
+
protected:
// Only test code should subclass AutofillManager.
friend class base::RefCounted<AutofillManager>;
@@ -114,12 +122,6 @@ class AutofillManager : public TabContentsObserver,
ScopedVector<FormStructure>* form_structures() { return &form_structures_; }
- // Called from our external delegate so it cannot be private.
- void OnFillAutoFillFormData(int query_id,
- const webkit_glue::FormData& form,
- const webkit_glue::FormField& field,
- int unique_id);
-
// Exposed for testing.
AutofillExternalDelegate* external_delegate() {
return external_delegate_;
@@ -152,15 +154,11 @@ class AutofillManager : public TabContentsObserver,
void OnQueryFormFieldAutofill(int query_id,
const webkit_glue::FormData& form,
const webkit_glue::FormField& field,
- const gfx::Rect& bounding_box);
- void OnFillAutofillFormData(int query_id,
- const webkit_glue::FormData& form,
- const webkit_glue::FormField& field,
- int unique_id);
+ const gfx::Rect& bounding_box,
+ bool display_warning);
void OnShowAutofillDialog();
void OnDidPreviewAutofillFormData();
- void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
- void OnDidShowAutofillSuggestions(bool is_new_popup);
+ void OnDidEndTextFieldEditing();
void OnHideAutofillPopup();
// Fills |host| with the RenderViewHost for this tab.

Powered by Google App Engine
This is Rietveld 408576698