Moving AutofillAgent Logic into Browser

chrome/browser/autofill/autofill_manager.h

Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index d03b22d36b6a1821cd95dd3604ded8e301deec61..b1187dc53dc11933ab3c07222747dc103a906c4a 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -64,6 +64,15 @@ class AutofillManager : public TabContentsObserver,
     external_delegate_ = delegate;
   }
 
+  // AutofillDownloadManager::Observer:

[Ilya Sherman, 2011/11/17 02:24:37]

nit: Please remove this line -- these are not AutofillDownloadManager::Observer
methods.

[csharp, 2011/11/18 18:15:10]

Done.

+  // Called from our external delegate so they cannot be private.
+  void OnFillAutoFillFormData(int query_id,
+                              const webkit_glue::FormData& form,
+                              const webkit_glue::FormField& field,
+                              int unique_id);
+  void OnDidShowAutofillSuggestions(bool is_new_popup);
+  void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
+
  protected:
   // Only test code should subclass AutofillManager.
   friend class base::RefCounted<AutofillManager>;
@@ -110,12 +119,6 @@ class AutofillManager : public TabContentsObserver,
 
   ScopedVector<FormStructure>* form_structures() { return &form_structures_; }
 
- // Called from our external delegate so it cannot be private.
-  void OnFillAutoFillFormData(int query_id,
-                              const webkit_glue::FormData& form,
-                              const webkit_glue::FormField& field,
-                              int unique_id);
-
   // Exposed for testing.
   AutofillExternalDelegate* external_delegate() {
     return external_delegate_;
@@ -145,15 +148,15 @@ class AutofillManager : public TabContentsObserver,
                             const base::TimeTicks& timestamp);
   void OnQueryFormFieldAutofill(int query_id,
                                 const webkit_glue::FormData& form,
-                                const webkit_glue::FormField& field);
+                                const webkit_glue::FormField& field,
+                                bool display_warning);
   void OnFillAutofillFormData(int query_id,
                               const webkit_glue::FormData& form,
                               const webkit_glue::FormField& field,
                               int unique_id);
   void OnShowAutofillDialog();
   void OnDidPreviewAutofillFormData();
-  void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
-  void OnDidShowAutofillSuggestions(bool is_new_popup);
+  void OnSetDidEndTextFieldEditing();
 
   // Fills |host| with the RenderViewHost for this tab.
   // Returns false if Autofill is disabled or if the host is unavailable.