Add some language aliases to track changes to base/ui/l10n_util.cc.

Add some language aliases to track changes to base/ui/l10n_util.cc.

Alias Australian, Canadian, New Zealand and South African English to British English, and explicitly alias "es-es" to "es" so it doesn't become "es-419" by way of the wildcard match.

BUG=none
TEST=covered by installer_util_unittests.exe --gtest_filter=*LanguageSelectorAliasTest*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112471

[grt (UTC plus 2), 2011-11-16 15:42:32]

Hi Jungshik,

This CL tracks your changes in http://crrev.com/102048 for the installer. 
Thanks.

[grt (UTC plus 2), 2011-11-22 02:08:58]

On 2011/11/16 15:42:32, grt wrote:
> Hi Jungshik,
> 
> This CL tracks your changes in http://crrev.com/102048 for the installer. 
> Thanks.

ping

[jungshik at Google, 2011-11-29 23:30:37]

Sorry for the delay. Thank you for fixing this. LGTM

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
File chrome/installer/util/language_selector_unittest.cc (right):

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
chrome/installer/util/language_selector_unittest.cc:185:
::testing::Values(L"zh-cht", L"zh-hant", L"zh-hk", L"zh-mk",
MK is for Macedonia. So, it should be dropped.

[jungshik at Google, 2011-11-29 23:31:32]

Would this fix bug 94906? 



On 2011/11/29 23:30:37, Jungshik Shin wrote:
> Sorry for the delay. Thank you for fixing this. LGTM
> 
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> File chrome/installer/util/language_selector_unittest.cc (right):
> 
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> chrome/installer/util/language_selector_unittest.cc:185:
> ::testing::Values(L"zh-cht", L"zh-hant", L"zh-hk", L"zh-mk",
> MK is for Macedonia. So, it should be dropped.

[jungshik at Google, 2011-11-29 23:35:53]

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
File chrome/installer/util/language_selector.cc (right):

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
chrome/installer/util/language_selector.cc:73: { L"zh-mk", IDS_L10N_OFFSET_ZH_TW
},
I think this line came from my 'typo' in l10n_util.cc that has since been fixed.
I guess we can't remove this line. MK is Macedonia rather than Macau.  Macau is
MO.

[jungshik at Google, 2011-11-29 23:36:21]

On 2011/11/29 23:35:53, Jungshik Shin wrote:
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> File chrome/installer/util/language_selector.cc (right):
> 
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> chrome/installer/util/language_selector.cc:73: { L"zh-mk",
IDS_L10N_OFFSET_ZH_TW
> },
> I think this line came from my 'typo' in l10n_util.cc that has since been
fixed.
> I guess we can't remove this line. MK is Macedonia rather than Macau.  Macau
is
> MO.

Ooops.  I meant we CAN remove 'MK' line.

[jungshik at Google, 2011-11-29 23:42:32]

On 2011/11/29 23:31:32, Jungshik Shin wrote:
> Would this fix bug 94906? 

I guess it'll 'fix' only partially. At installation time, en-AU will be mapped
to en-GB. Otherwise, it'll not. We may have to do something in base/i18n/win/*. 


Anyway, with 'MK' related lines removed, this CL is LGTM. 


> 
> 
> 
> On 2011/11/29 23:30:37, Jungshik Shin wrote:
> > Sorry for the delay. Thank you for fixing this. LGTM
> > 
> >
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> > File chrome/installer/util/language_selector_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
> > chrome/installer/util/language_selector_unittest.cc:185:
> > ::testing::Values(L"zh-cht", L"zh-hant", L"zh-hk", L"zh-mk",
> > MK is for Macedonia. So, it should be dropped.

[commit-bot: I haz the power, 2011-12-01 14:29:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/8488006/12001

[grt (UTC plus 2), 2011-12-01 14:31:11]

Thanks for the review.  Sending to the CQ now.

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
File chrome/installer/util/language_selector.cc (right):

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
chrome/installer/util/language_selector.cc:73: { L"zh-mk", IDS_L10N_OFFSET_ZH_TW
},
On 2011/11/29 23:35:54, Jungshik Shin wrote:
> I think this line came from my 'typo' in l10n_util.cc that has since been
fixed.
> I guess we can't remove this line. MK is Macedonia rather than Macau.  Macau
is
> MO.   

Thanks for spotting that.  Done.

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
File chrome/installer/util/language_selector_unittest.cc (right):

http://codereview.chromium.org/8488006/diff/2001/chrome/installer/util/langua...
chrome/installer/util/language_selector_unittest.cc:185:
::testing::Values(L"zh-cht", L"zh-hant", L"zh-hk", L"zh-mk",
On 2011/11/29 23:30:37, Jungshik Shin wrote:
> MK is for Macedonia. So, it should be dropped. 

Done.

[commit-bot: I haz the power, 2011-12-01 16:15:53]

Change committed as 112471