Crash on error or assert message in Debug build

Crash on error or assert message in Debug build

r=rvargas
bug=102940
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110181

[rvargas (doing something else), 2011-11-07 18:53:49]

I don't see this file fixing the issue. As far as I can see, VS has this file in
the list of excluded files for base.

To double check, calling isalnum(-1), should trigger a crash.

http://codereview.chromium.org/8487004/diff/1/base/allocator/generic_allocato...
File base/allocator/generic_allocators.cc (right):

http://codereview.chromium.org/8487004/diff/1/base/allocator/generic_allocato...
base/allocator/generic_allocators.cc:110: if (reportType ==  0)  // _CRT_WARN
It is not clear to me that this is the right thing to do. On one hand, this
behavior is intended to be run-time controllable by the caller... on the other,
we have a general policy of treating warning as errors for all code we control.

Given that, I'd be inclined to crash on warnings too.

http://codereview.chromium.org/8487004/diff/1/base/allocator/generic_allocato...
base/allocator/generic_allocators.cc:114: *p = '0';
Can we just DCHECK here instead? You're probably trying to avoid circular
dependencies, but if we can work something out it would be much better to rely
on the standard processing of exceptions that we have.

[jar (doing other things), 2011-11-12 02:39:51]

I switched to debug asserts.

FYI: I already found and fixed an assertion (in someone's code that uses STL)...
so this is a nice change... and a good suggestion by rvargas!

[rvargas (doing something else), 2011-11-12 02:47:12]

LGTM