Remove 13 exit time constructors and 3 static initializers

Remove 13 exit time constructors and 3 static initializers

BUG=101600, 94925
TEST=none
TBR=vandebo,viettrungluu

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108838

[Nico, 2011-11-06 00:35:42]

mark: Review.

sky, akalin, willchan, dmichael, viettrungluu, vandebo: OWNERS stamps.

[willchan no longer on Chromium, 2011-11-06 07:16:46]

net/ LGTM

http://codereview.chromium.org/8487001/diff/2001/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/8487001/diff/2001/net/url_request/url_request....
net/url_request/url_request.cc:65: base::AutoLock
lock(*g_next_url_request_identifier_lock.Pointer());
You could also use .Get() instead of .Pointer().

[Mark Mentovai, 2011-11-06 14:09:01]

LGTM otherwise

http://codereview.chromium.org/8487001/diff/2001/net/base/net_util.cc
File net/base/net_util.cc (right):

http://codereview.chromium.org/8487001/diff/2001/net/base/net_util.cc#newcode500
net/base/net_util.cc:500: const icu::UnicodeSet, kASCIILetters, (0x61, 0x7a)); 
// [a-z]
('a', 'z') works?

http://codereview.chromium.org/8487001/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):

http://codereview.chromium.org/8487001/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:412: nacl::string
kGeneratedObjectFileName() {
No longer a constant, get rid of the k.

[Nico, 2011-11-06 17:30:37]

Thanks!

Pending OWNERS stamps: sky, akalin, dmichael, viettrungluu, vandebo

http://codereview.chromium.org/8487001/diff/2001/net/base/net_util.cc
File net/base/net_util.cc (right):

http://codereview.chromium.org/8487001/diff/2001/net/base/net_util.cc#newcode500
net/base/net_util.cc:500: const icu::UnicodeSet, kASCIILetters, (0x61, 0x7a)); 
// [a-z]
On 2011/11/06 14:09:02, Mark Mentovai wrote:
> ('a', 'z') works?

D'oh!ne.

http://codereview.chromium.org/8487001/diff/2001/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/8487001/diff/2001/net/url_request/url_request....
net/url_request/url_request.cc:65: base::AutoLock
lock(*g_next_url_request_identifier_lock.Pointer());
On 2011/11/06 07:16:46, willchan wrote:
> You could also use .Get() instead of .Pointer().

Done.

http://codereview.chromium.org/8487001/diff/2001/ppapi/native_client/src/trus...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (right):

http://codereview.chromium.org/8487001/diff/2001/ppapi/native_client/src/trus...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:412: nacl::string
kGeneratedObjectFileName() {
On 2011/11/06 14:09:02, Mark Mentovai wrote:
> No longer a constant, get rid of the k.

Done.

[sky, 2011-11-07 03:17:50]

Rubber stamp LGTM

[dmichael (off chromium), 2011-11-07 04:17:24]

Rubber stamp lgtm
On Nov 6, 2011 8:17 PM, <sky@chromium.org> wrote:

> Rubber stamp LGTM
>
>
http://codereview.chromium.**org/8487001/<http://codereview.chromium.org/8487...
>

[akalin, 2011-11-07 04:20:56]

jingle LGTM

[commit-bot: I haz the power, 2011-11-07 04:32:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8487001/5004

[commit-bot: I haz the power, 2011-11-07 06:03:31]

Change committed as 108838

[vandebo (ex-Chrome), 2011-11-07 17:46:59]

printing LGTM