Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 8486024: Fix flakyness with TextfieldViewsModelTest.Clipboard. (Closed)

Created:
9 years, 1 month ago by Alexei Svitkine (slow)
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, penghuang+watch_chromium.org, Paweł Hajdan Jr., James Su, dhollowa
Visibility:
Public.

Description

Fix flakyness with TextfieldViewsModelTest.Clipboard. Set the clipboard text initially rather than using whatever happened to be in the clipboard at the time of the test. BUG=none TEST=Copy some non-ASCII text before running TextfieldViewsModelTest.Clipboard. Then, run the test. It should not fail. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M views/controls/textfield/textfield_views_model_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
9 years, 1 month ago (2011-11-16 20:39:39 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-16 21:03:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8486024/1
9 years, 1 month ago (2011-11-16 21:08:47 UTC) #3
commit-bot: I haz the power
Try job failure for 8486024-1 (retry) on win_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-16 22:30:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8486024/1
9 years, 1 month ago (2011-11-16 23:45:46 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 05:11:55 UTC) #6
Change committed as 110434

Powered by Google App Engine
This is Rietveld 408576698