ui/gfx/compositor/layer_animation_element.cc - Issue 8486020: compositor_unittests target is unimplmented on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/compositor/layer_animation_element.cc

Issue 8486020: compositor_unittests target is unimplmented on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Nico's comments (#2) Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/compositor/layer_animation_element.cc

diff --git a/ui/gfx/compositor/layer_animation_element.cc b/ui/gfx/compositor/layer_animation_element.cc

index 8aca397d04508e4eabaa30dfea1bdacb9acbad53..c388d983ed6c8b619974469978f3569366d71218 100644

--- a/ui/gfx/compositor/layer_animation_element.cc

+++ b/ui/gfx/compositor/layer_animation_element.cc

@@ -46,8 +46,10 @@ class TransformTransition : public LayerAnimationElement {

}

virtual void OnProgress(double t, LayerAnimationDelegate* delegate) OVERRIDE {

+#if !defined(OS_MACOSX)

piman 2011/11/16 20:55:59 Why? I don't see what's mac-adverse here.

dhollowa 2011/11/16 23:28:59 ui/base/animation/tween.h:41 is #ifdef'd out on Ma

delegate->SetTransformFromAnimation(

Tween::ValueBetween(t, start_, target_));

+#endif

}

virtual void OnGetTarget(TargetValue* target) const OVERRIDE {