compositor_unittests target is unimplmented on Mac

ui/gfx/native_widget_types.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_NATIVE_WIDGET_TYPES_H_
 #define UI_GFX_NATIVE_WIDGET_TYPES_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "ui/base/ui_export.h"
@@ skipping 209 matching lines @@
 // window id.
 #if defined(OS_WIN)
   typedef HWND PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = NULL;
 #elif defined(USE_WAYLAND)
   typedef struct wl_egl_window* PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = NULL;
 #elif defined(USE_X11)
   typedef unsigned long PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = 0;
+#elif defined(USE_WEBKIT_COMPOSITOR) && defined(OS_MACOSX)

[piman, 2011/11/16 20:55:59]

Same here, I don't think USE_WEBKIT_COMPOSITOR is what you want.
If anything, VIEWS_COMPOSITOR. But even then, would things go wrong if it was
always defined this way? I'd rather avoid UI-level concepts leaking into the
infrastructure.

[dhollowa, 2011/11/16 23:28:59]

I think the correct designation is "Aura-Mac" i.e. USE_AURA && OS_MACOSX.

Mac-Aura is like a different "platform" than regular non-Aura Mac.  The regular
non-Aura Mac treats PluginWindowHandle as an id having nothing to do with a
platform window or view.  But with Mac-Aura the UI is drawn into a given NSView.

I would propose we keep the #ifdef'd separation but use USE_AURA && OS_MACOSX
(and not USE_WEBKIT_COMPOSITOR).

On 2011/11/16 20:55:59, piman wrote:

+  // USE_WEBKIT_COMPOSITOR is defined in service of the USE_AURA port.  These
+  // definitions are currently not in use (or tested) beyond that.
+  typedef NSView* PluginWindowHandle;
+  const PluginWindowHandle kNullPluginWindow = 0;
 #else
   // On OS X we don't have windowed plugins.
   // We use a NULL/0 PluginWindowHandle in shared code to indicate there
   // is no window present, so mirror that behavior here.
   //
   // The GPU plugin is currently an exception to this rule. As of this
   // writing it uses some NPAPI infrastructure, and minimally we need
   // to identify the plugin instance via this window handle. When the
   // GPU plugin becomes a full-on GPU process, this typedef can be
   // returned to a bool. For now we use a type large enough to hold a
   // pointer on 64-bit architectures in case we need this capability.
   typedef uint64 PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = 0;
 #endif
 
 // AcceleratedWidget provides a surface to compositors to paint pixels.
 #if defined(OS_WIN)
 typedef HWND AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #elif defined(USE_WAYLAND)
 typedef struct wl_egl_window* AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #elif defined(USE_X11)
 typedef unsigned long AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = 0;
+#elif defined(USE_WEBKIT_COMPOSITOR) && defined(OS_MACOSX)
+// USE_WEBKIT_COMPOSITOR is defined in service of the USE_AURA port.  These
+// definitions are currently not in use (or tested) beyond that.
+typedef NSView* AcceleratedWidget;
+const AcceleratedWidget kNullAcceleratedWidget = 0;
 #else
 typedef void* AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #endif
 
 }  // namespace gfx
 
 #endif  // UI_GFX_NATIVE_WIDGET_TYPES_H_