compositor_unittests target is unimplmented on Mac

ui/gfx/native_widget_types.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_NATIVE_WIDGET_TYPES_H_
 #define UI_GFX_NATIVE_WIDGET_TYPES_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "ui/base/ui_export.h"
@@ skipping 209 matching lines @@
 // window id.
 #if defined(OS_WIN)
   typedef HWND PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = NULL;
 #elif defined(USE_WAYLAND)
   typedef struct wl_egl_window* PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = NULL;
 #elif defined(USE_X11)
   typedef unsigned long PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = 0;
+#elif defined(USE_WEBKIT_COMPOSITOR) && defined(OS_MACOSX)

[Nico, 2011/11/16 19:11:13]

I don't know what the longer-term plan for this is, but these defines sound
generic enough that people might think USE_WEBKIT_COMPOSITOR could work in
desktop chrome. Can you add a comment that this only makes sense with the aura
prototype, and that getting this into "normal" chrome is fairly involved?

[dhollowa, 2011/11/16 19:59:18]

Done.  Yes.

I also wonder about the possible merging of |AcceleratedWidget| and
|PluginWindowHandle|.  They're almost identical, and the gl/gl_surface*
interfaces consume |PluginWindowHandle| but |AcceleratedWidget| seems more
appropriate somehow.


On 2011/11/16 19:11:13, Nico wrote:

+  typedef NSView* PluginWindowHandle;
+  const PluginWindowHandle kNullPluginWindow = 0;
 #else
   // On OS X we don't have windowed plugins.
   // We use a NULL/0 PluginWindowHandle in shared code to indicate there
   // is no window present, so mirror that behavior here.
   //
   // The GPU plugin is currently an exception to this rule. As of this
   // writing it uses some NPAPI infrastructure, and minimally we need
   // to identify the plugin instance via this window handle. When the
   // GPU plugin becomes a full-on GPU process, this typedef can be
   // returned to a bool. For now we use a type large enough to hold a
   // pointer on 64-bit architectures in case we need this capability.
   typedef uint64 PluginWindowHandle;
   const PluginWindowHandle kNullPluginWindow = 0;
 #endif
 
 // AcceleratedWidget provides a surface to compositors to paint pixels.
 #if defined(OS_WIN)
 typedef HWND AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #elif defined(USE_WAYLAND)
 typedef struct wl_egl_window* AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #elif defined(USE_X11)
 typedef unsigned long AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = 0;
+#elif defined(USE_WEBKIT_COMPOSITOR) && defined(OS_MACOSX)
+typedef NSView* AcceleratedWidget;
+const AcceleratedWidget kNullAcceleratedWidget = 0;
 #else
 typedef void* AcceleratedWidget;
 const AcceleratedWidget kNullAcceleratedWidget = NULL;
 #endif
 
 }  // namespace gfx
 
 #endif  // UI_GFX_NATIVE_WIDGET_TYPES_H_