Issue 8486019: Fix ExtensionServiceTest by moving base::ShadowingAtExitManager into the fixture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8486019: Fix ExtensionServiceTest by moving base::ShadowingAtExitManager into the fixture. (Closed)

Created:
9 years, 1 month ago by Robert Sesek

Modified:
9 years, 1 month ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Alexander Potapenko, Erik does not do reviews, Timur Iskhodzhanov, mihaip+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix ExtensionServiceTest by moving base::ShadowingAtExitManager into the fixture. BUG=104443 TEST=unit_tests --gtest_filter=ExtensionServiceTest\* under valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110724

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	chrome/browser/extensions/extension_service_unittest.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	5 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

This just ensures that all singletons, specifically PluginService, get destroyed for each test.

9 years, 1 month ago (2011-11-16 18:52:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/8486019/1

9 years, 1 month ago (2011-11-17 14:48:01 UTC) #3

commit-bot: I haz the power

9 years, 1 month ago (2011-11-17 15:34:16 UTC) #4

Try job failure for 8486019-1 (retry) on linux_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages