Issue 8486014: WebUI TaskManager: Make sort rows including "N/A" correctly.

Issue 8486014: WebUI TaskManager: Make sort rows including "N/A" correctly. (Closed)

Created:
9 years, 1 month ago by yoshiki

Modified:
9 years, 1 month ago

Reviewers:
mazda

CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebUI TaskManager: Make sort rows including "N/A" correctly. Fixed the problem that sort didn't work correctly when some rows are "N/A". BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110498

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fix #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/resources/task_manager/main.js	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mazda

lgtm with nits http://codereview.chromium.org/8486014/diff/1/chrome/browser/resources/task_manager/main.js File chrome/browser/resources/task_manager/main.js (right): http://codereview.chromium.org/8486014/diff/1/chrome/browser/resources/task_manager/main.js#newcode198 chrome/browser/resources/task_manager/main.js:198: var aValue = aValues && aValues.length ...

9 years, 1 month ago (2011-11-17 06:50:55 UTC) #2

yoshiki

Thanks! http://codereview.chromium.org/8486014/diff/1/chrome/browser/resources/task_manager/main.js File chrome/browser/resources/task_manager/main.js (right): http://codereview.chromium.org/8486014/diff/1/chrome/browser/resources/task_manager/main.js#newcode198 chrome/browser/resources/task_manager/main.js:198: var aValue = aValues && aValues.length > 0 ...

9 years, 1 month ago (2011-11-17 13:00:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8486014/5001

9 years, 1 month ago (2011-11-17 13:00:20 UTC) #4

Change committed as 110498

Expand Messages | Collapse Messages