Issue 8486011: roll skia to 2695

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8486011: roll skia to 2695 (Closed)

Created:
9 years, 1 month ago by reed1

Modified:
9 years, 1 month ago

Reviewers:

CC:
chromium-reviews, vandebo (ex-Chrome), bungeman-skia

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

roll skia to 2695 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110328

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	skia/skia.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

epoger

9 years, 1 month ago (2011-11-16 16:36:55 UTC) #2

On 2011/11/16 13:59:51, reed1 wrote:

LGTM, with the following caveats based on trybot results.  The win_layout_rel
one is the only one I am really concerned about.

- win_layout_rel is failing one gpu test (canvas-radial-gradient-spreadMethod)
which does not appear to be flaky
- win crashed in chrome_framte_net_tests, but it looks like a non-code problem
- linux_chromeos failed 2 browser_tests, but I think those are flaky
- linux failed 3 ui_tests, but I think those are flaky

Expand Messages | Collapse Messages