Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: frog/type.dart

Issue 8481023: cleanup errors and fix a couple field negative tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/member.dart ('k') | frog/value.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/type.dart
diff --git a/frog/type.dart b/frog/type.dart
index cbffcbf96cea22cc01e1b5382d526cfdf84babe7..4d8b1377c43ceb393c590fa1665ad95680af0a43 100644
--- a/frog/type.dart
+++ b/frog/type.dart
@@ -820,7 +820,7 @@ class DefinedType extends Type {
&& definition.modifiers[0].kind == TokenKind.FACTORY) {
// constructorName for a factory is the type.
if (factories.getFactory(method.constructorName, method.name) != null) {
- world.error('duplicate factory definition of ${method.name}',
+ world.error('duplicate factory definition of "${method.name}"',
definition.span);
return;
}
@@ -836,20 +836,20 @@ class DefinedType extends Type {
members[propName] = prop;
}
if (prop is! PropertyMember) {
- world.error('property conflicts with field name: $propName',
+ world.error('property conflicts with field "$propName"',
definition.span);
return;
}
if (methodName[0] == 'g') {
if (prop.getter != null) {
- world.error('duplicate getter definition for $propName',
+ world.error('duplicate getter definition for "$propName"',
definition.span);
}
// TODO(jimhug): Validate zero parameters
prop.getter = method;
} else {
if (prop.setter != null) {
- world.error('duplicate setter definition for $propName',
+ world.error('duplicate setter definition for "$propName"',
definition.span);
}
// TODO(jimhug): Validate one parameters - match with getter?
@@ -859,7 +859,7 @@ class DefinedType extends Type {
}
if (members.containsKey(methodName)) {
- world.error('duplicate method definition of ${method.name}',
+ world.error('duplicate method definition of "${method.name}"',
definition.span);
return;
}
@@ -870,7 +870,7 @@ class DefinedType extends Type {
for (int i=0; i < definition.names.length; i++) {
var name = definition.names[i].name;
if (members.containsKey(name)) {
- world.error('duplicate field definition of $name',
+ world.error('duplicate field definition of "$name"',
definition.span);
return;
}
@@ -988,7 +988,6 @@ class DefinedType extends Type {
}
} else {
// TODO(jimhug): Will probably check types more than once - errors?
- //print('look')
if (interfaces != null && interfaces.length > 0) {
for (var i in interfaces) {
var ret = i.getMember(memberName);
« no previous file with comments | « frog/member.dart ('k') | frog/value.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698