Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: frog/library.dart

Issue 8481023: cleanup errors and fix a couple field negative tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/gen.dart ('k') | frog/member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/library.dart
diff --git a/frog/library.dart b/frog/library.dart
index bb4248f7c6aec45a2ce75f6dda857405913148af..ef855dd24da4f2981c2e57797094083b11ffe84f 100644
--- a/frog/library.dart
+++ b/frog/library.dart
@@ -176,8 +176,7 @@ class Library {
if (newRet != null) {
// TODO(jimhug): Should not need ret != newRet here or below.
if (ret != null && ret != newRet) {
- world.error('conflicting types for "$name"', ret.span);
- world.error('conflicting types for "$name"', newRet.span);
+ world.error('conflicting types for "$name"', ret.span, newRet.span);
} else {
ret = newRet;
}
@@ -198,9 +197,8 @@ class Library {
// TODO(jimhug): Shares too much code with body of loop.
if (newRet != null) {
if (ret != null && ret != newRet) {
- world.error('conflicting members for "$name"', span);
- world.error('conflicting members for "$name"', ret.span);
- world.error('conflicting members for "$name"', newRet.span);
+ world.error('conflicting members for "$name"',
+ span, ret.span, newRet.span);
} else {
ret = newRet;
}
@@ -213,9 +211,8 @@ class Library {
newRet = imported.library.topType.getMember(name);
if (newRet != null) {
if (ret != null && ret != newRet) {
- world.error('conflicting members for "$name"', span);
- world.error('conflicting members for "$name"', ret.span);
- world.error('conflicting members for "$name"', newRet.span);
+ world.error('conflicting members for "$name"',
+ span, ret.span, newRet.span);
} else {
ret = newRet;
}
@@ -354,10 +351,7 @@ class _LibraryVisitor implements TreeVisitor {
}
var newLib = library.addImport(filename, prefix);
- if (newLib.name == null && !filename.startsWith('dart:')) {
- world.info('imported library "$name" has no #library directive',
- node.span);
- }
+ // TODO(jimhug): Add check that imported library has a #library
break;
case "source":
« no previous file with comments | « frog/gen.dart ('k') | frog/member.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698