cleanup errors and fix a couple field negative tests

frog/world.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** The one true [World]. */
 World world;
 
 /**
  * Should be called exactly once to setup singleton world.
  * Can use world.reset() to reinitialize.
@@ skipping 342 matching lines @@
 
   resolveAll() {
     for (var lib in libraries.getValues()) {
       lib.resolve();
     }
   }
 
   // ********************** Message support ***********************
 
   void _message(String message, SourceSpan span, SourceSpan span1,
-      bool throwing) {
+      SourceSpan span2, bool throwing) {
     var text = message;
     if (span != null) {
       text = span.toMessageString(message);
     }
     print(text);
     if (span1 != null) {
       print(span1.toMessageString(message));
     }
+    if (span2 != null) {
+      print(span2.toMessageString(message));
+    }
 
     if (throwing) {
       throw new CompilerException(message, span);
     }
   }
 
   /** [message] is considered a static compile-time error by the Dart lang. */
-  void error(String message, [SourceSpan span, SourceSpan span1]) {
+  void error(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     errors++;
-    _message('error: $message', span, span1, options.throwOnErrors);
+    _message('error: $message', span, span1, span2, options.throwOnErrors);
   }
 
   /** [message] is considered a type warning by the Dart lang. */
-  void warning(String message, [SourceSpan span, SourceSpan span1]) {
+  void warning(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     warnings++;
     if (options.showWarnings) {
-      _message('warning: $message', span, span1, options.throwOnWarnings);
+      _message('warning: $message', span, span1, span2, options.throwOnWarnings);
     }
   }
 
   /** [message] at [location] is so bad we can't generate runnable code. */
-  void fatal(String message, [SourceSpan span, SourceSpan span1]) {
+  void fatal(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     errors++;
     seenFatal = true;
-    _message('fatal: $message', span, span1,
+    _message('fatal: $message', span, span1, span2,
      options.throwOnFatal || options.throwOnErrors);
   }
 
   /** [message] at [location] is about a bug in the compiler. */
-  void internalError(String message, [SourceSpan span, SourceSpan span1]) {
-    _message('We are sorry, but... $message', span, span1, true);
+  void internalError(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
+    _message('We are sorry, but... $message', span, span1, span2, true);
   }
 
   /**
    * [message] at [location] will tell the user about what the compiler
    * is doing.
    */
-  void info(String message, [SourceSpan span, SourceSpan span1]) {
+  void info(String message, [SourceSpan span, SourceSpan span1, SourceSpan span2]) {
     if (options.showInfo) {
-      _message('info: $message', span, span1, false);
+      _message('info: $message', span, span1, span2, false);
     }
   }
 
   bool get hasErrors() => errors > 0;
 
   void printStatus() {
     info('compiled $dartBytesRead bytes Dart -> $jsBytesWritten bytes JS');
     if (hasErrors) {
       print('compilation failed with $errors errors');
     } else {
       if (warnings > 0) {
         info('compilation completed successfully with $warnings warnings');
       } else {
         info('compilation completed sucessfully');
       }
     }
   }
 
   withTiming(String name, f()) {
     final sw = new StopWatch();
     sw.start();
     var result = f();
     sw.stop();
     info('$name in ${sw.elapsedInMs()}msec');
     return result;
   }
 }