Issue 8480035: Mock implementation of overridePreference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8480035: Mock implementation of overridePreference. (Closed)

Created:
9 years, 1 month ago by Takashi Toyoshima

Modified:
9 years, 1 month ago

Reviewers:
jorlow, Yuta Kitamura

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mock implementation of overridePreference. Without this change, the ui_tests cause timeout. But still failed with it. BUG=104940 TEST=ui_tests --gtest_filter="*WorkerWebSocket*" --gtest_also_run_disabled_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110893

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/test/data/layout_tests/layout_test_controller.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Could anyone review this change? For now, I choose yutak@ and jorlow@. yutak is familier ...

9 years, 1 month ago (2011-11-21 06:39:38 UTC) #1

Yuta Kitamura

LGTM. IIRC jorlow doesn't work for Chromium anymore. I guess it's fine to commit anyway ...

9 years, 1 month ago (2011-11-21 07:01:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8480035/1

9 years, 1 month ago (2011-11-21 07:30:36 UTC) #3

Change committed as 110893

Expand Messages | Collapse Messages