Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Issue 8480033: CrOs: Remove 29 exit time destructors and 8 static initializers. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
satorux1, Ryan Sleevi
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

CrOs: Remove 29 exit time destructors and 8 static initializers. BUG=101600, 94925 TEST=none TBR=satorux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110883

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : ! #

Total comments: 1

Patch Set 4 : reupload #

Patch Set 5 : reupload 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -131 lines) Patch
M chrome/browser/chromeos/cros/native_network_parser.cc View 14 chunks +30 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.cc View 6 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/dbus/power_manager_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
chrome/browser/chromeos/login/registration_screen.h View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 1 5 chunks +16 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source_chromeos.cc View 1 2 5 chunks +56 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
lgtm
9 years, 1 month ago (2011-11-21 04:57:59 UTC) #1
Ryan Sleevi
http://codereview.chromium.org/8480033/diff/4001/chrome/browser/ui/webui/fileicon_source_chromeos.cc File chrome/browser/ui/webui/fileicon_source_chromeos.cc (right): http://codereview.chromium.org/8480033/diff/4001/chrome/browser/ui/webui/fileicon_source_chromeos.cc#newcode114 chrome/browser/ui/webui/fileicon_source_chromeos.cc:114: }; Just following up from the IRC comments.. Rather ...
9 years, 1 month ago (2011-11-21 05:06:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8480033/4001
9 years, 1 month ago (2011-11-21 05:16:50 UTC) #3
commit-bot: I haz the power
Can't process patch for file chrome/browser/chromeos/login/registration_screen.h. File's status is None, patchset upload is incomplete.
9 years, 1 month ago (2011-11-21 05:16:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8480033/1014
9 years, 1 month ago (2011-11-21 05:18:00 UTC) #5
commit-bot: I haz the power
Can't process patch for file chrome/browser/chromeos/login/registration_screen.h. File's status is None, patchset upload is incomplete.
9 years, 1 month ago (2011-11-21 05:18:02 UTC) #6
Nico
9 years, 1 month ago (2011-11-21 05:21:20 UTC) #7
satorux: OWNERS stamp, please

Powered by Google App Engine
This is Rietveld 408576698