Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 8480032: Add ChromeBrowserMainExtraParts for non main parts. (take 3) (Closed)

Created:
9 years, 1 month ago by stevenjb
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add ChromeBrowserMainExtraParts for non main parts. (take 3) This was originally submitted as http://codereview.chromium.org/8539038/ which was reverted because of a failing test on win. This reverts the code back to a single instance of BrowserMainParts, with auxillary parts (Gtk, Views, Aura, Touch) implemented from a new base class, ChromeBrowserParts, which has a Chrome specific interface, allowing initialization to be better subdivided. This should fix the notifications auto tests. This CL also addresses the test failure on win (and a test failure on linux_chromeos triggered by the windows fix). BUG=103821 TEST=Make sure all tests and autotests run TBR=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110972

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -574 lines) Patch
M chrome/browser/chrome_browser_main.h View 7 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 10 chunks +45 lines, -27 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts_aura.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_aura.cc View 3 chunks +4 lines, -26 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts_gtk.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_gtk.cc View 3 chunks +6 lines, -27 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts_touch.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_touch.cc View 1 chunk +4 lines, -8 lines 0 comments Download
A chrome/browser/chrome_browser_main_extra_parts_views.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + chrome/browser/chrome_browser_main_extra_parts_views.cc View 1 3 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 3 chunks +11 lines, -19 lines 0 comments Download
D chrome/browser/chrome_browser_parts_aura.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/chrome_browser_parts_aura.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/chrome_browser_parts_gtk.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chrome_browser_parts_gtk.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/chrome_browser_parts_touch.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/chrome_browser_parts_touch.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/chrome_browser_parts_views.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/chrome_browser_parts_views.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +28 lines, -23 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/browser_main_loop.cc View 5 chunks +19 lines, -31 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 3 chunks +5 lines, -10 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
stevenjb
Same as http://codereview.chromium.org/8598005/, without the change to DesktopNotificationServiceFactory::BuildServiceInstanceFor().
9 years, 1 month ago (2011-11-21 17:05:03 UTC) #1
jam
9 years, 1 month ago (2011-11-21 18:28:31 UTC) #2
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698