Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 8480027: Revert 109678 - WebUI test framework: fix Mock4JS verification, allow chrome.send passthrough. (Closed)

Created:
9 years, 1 month ago by nduca
Modified:
9 years, 1 month ago
Reviewers:
Sheridan Rawlins
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 109678 - WebUI test framework: fix Mock4JS verification, allow chrome.send passthrough. 1) Add test for Bug 99970 Comment 6 & fix 2) Allow chrome.send to be mocked outside of preLoad call. 3) add chrome.originalSend to allow mocked messages to pass through to C++. Also to address need for .cc file to be correct for clang, and prevent ugliness in js with a lot of GEN lines, allow the header and .cc to not have a suffix, and the generated file to end in -gen.cc. While doing this, addressed crbug.com/102794 to put in <(INTERMEDIATE_DIR) preventing collisions across rules. R=flackr@chromium.org,wyck@chromium.org BUG=103740, 99970, 102794 TEST=browser_tests --gtest_filter=Mock4JS*.* AND ChromeSend*.* Review URL: http://codereview.chromium.org/8515016 TBR=scr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -272 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/webui/chrome_send_browsertest.js View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/test/data/webui/chrome_send_browsertest-inl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/test/data/webui/mock4js_browsertest.js View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/test/data/webui/test_api.js View 7 chunks +13 lines, -52 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nduca
9 years, 1 month ago (2011-11-11 20:07:04 UTC) #1
Sheridan Rawlins
9 years, 1 month ago (2011-11-11 20:15:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698