Issue 8480026: Fix the default search app icon to conform with webstore guidlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8480026: Fix the default search app icon to conform with webstore guidlines. (Closed)

Created:
9 years, 1 month ago by Roger Tawa OOO till Jul 10th

Modified:
9 years, 1 month ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the default search app icon to conform with webstore guidlines. BUG=102431 TEST=Make sure that the default search app's icon meets the criteria listed in the bug description Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109669

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/default_apps/external_extensions.json	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	chrome/browser/resources/default_apps/search.crx	View		Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM http://codereview.chromium.org/8480026/diff/1/chrome/browser/resources/default_apps/external_extensions.json File chrome/browser/resources/default_apps/external_extensions.json (right): http://codereview.chromium.org/8480026/diff/1/chrome/browser/resources/default_apps/external_extensions.json#newcode14 chrome/browser/resources/default_apps/external_extensions.json:14: "external_version": "0.0.0.13" Will the store version be updated ...

9 years, 1 month ago (2011-11-11 03:33:57 UTC) #2

Roger Tawa OOO till Jul 10th

9 years, 1 month ago (2011-11-11 15:23:30 UTC) #3

Hi Mihai,

I am not sure exactly when the store will be updated, but I'll check with Tyler.
 Thanks.

Expand Messages | Collapse Messages