Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 848002: Changes to enable dev in stateful partition for usb and startup (Closed)

Created:
10 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
gauravsh, tedbo
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Changes to enable dev in stateful partition for usb and startup

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Patch Set 3 : Add legacy support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -44 lines) Patch
M src/platform/init/chromeos_startup View 1 chunk +6 lines, -0 lines 0 comments Download
M src/scripts/file_copy.py View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scripts/image_to_usb.sh View 1 2 5 chunks +50 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sosa
Modifies image_to_usb to compensate for change in build_image and ensure the stateful partition gets carried ...
10 years, 9 months ago (2010-03-11 03:21:42 UTC) #1
gauravsh
http://codereview.chromium.org/848002/diff/1/4 File src/scripts/image_to_usb.sh (right): http://codereview.chromium.org/848002/diff/1/4#newcode180 src/scripts/image_to_usb.sh:180: seek_bytes=$(( (${PART_SIZE}) + 512 )) I am slightly confused ...
10 years, 9 months ago (2010-03-11 04:09:48 UTC) #2
sosa
http://codereview.chromium.org/848002/diff/1/4 File src/scripts/image_to_usb.sh (right): http://codereview.chromium.org/848002/diff/1/4#newcode180 src/scripts/image_to_usb.sh:180: seek_bytes=$(( (${PART_SIZE}) + 512 )) You're right. I didn't ...
10 years, 9 months ago (2010-03-11 18:56:14 UTC) #3
gauravsh
lgtm
10 years, 9 months ago (2010-03-11 19:12:18 UTC) #4
sosa
I decided to add legacy support before pushing out this change (i.e. image_to_usb now assumes ...
10 years, 9 months ago (2010-03-11 22:35:58 UTC) #5
gauravsh
10 years, 9 months ago (2010-03-11 22:54:19 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698