chrome/browser/ui/webui/cloud_print_signin_dialog.cc - Issue 8479042: UI polish for certificate viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/cloud_print_signin_dialog.cc

Issue 8479042: UI polish for certificate viewer (Closed) Base URL: /usr/local/google/home/bshe/NoTouchChromium/../TouchChromium/src/@trunk

Patch Set: Remove body margins of two internal pages(due to the changes in tabs.css file). Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/cloud_print_signin_dialog.cc

diff --git a/chrome/browser/ui/webui/cloud_print_signin_dialog.cc b/chrome/browser/ui/webui/cloud_print_signin_dialog.cc

index d9cce3e72a04222a1c3562febea5eb9e5abe71f9..907577cc328c246178c84ae9b610d4e14cd33135 100644

--- a/chrome/browser/ui/webui/cloud_print_signin_dialog.cc

+++ b/chrome/browser/ui/webui/cloud_print_signin_dialog.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/dialog_style.h"

#include "chrome/browser/ui/webui/html_dialog_ui.h"

#include "chrome/browser/ui/webui/print_preview_ui.h"

#include "chrome/common/pref_names.h"

@@ -180,7 +181,8 @@ void CreateCloudPrintSigninDialogImpl(TabContents* parent_tab) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

HtmlDialogUIDelegate* dialog_delegate =

new CloudPrintSigninDelegate(parent_tab);

- BrowserList::GetLastActive()->BrowserShowHtmlDialog(dialog_delegate, NULL);

+ BrowserList::GetLastActive()->BrowserShowHtmlDialog(dialog_delegate, NULL,

+ STYLE_GENERIC);

flackr 2011/11/21 20:43:31 One argument per line.

bshe 2011/11/22 16:26:24 Done.

}

void CreateCloudPrintSigninDialog(TabContents* parent_tab) {